Rahul/supress websocket connection reattempt #5649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguenther
reviewed
Nov 13, 2024
ironfish/src/network/peers/peer.ts
Outdated
| this.logger.warn('Already have a WebSocket connection, ignoring the new one') | ||
| this.logger.debug( | ||
| `Already have a WebSocket connection with ${ | ||
| connection.address?.host || 'Unknown host' |
There was a problem hiding this comment.
Yeah I'm fine with bumping down this log level. I think given we've let the error ride for a while without investigating it, it'd be better to bump down to a debug to clean up our log output.
The only thing I'd suggest changing here is I think we should log this.displayName instead of connection.address.host, since peers are unique based on their identity rather than their network address. Or at least log something like "Peer {displayName} already has a websocket connection to {this.address}, ignoring new one at ${connection.address}"
patnir
force-pushed
the
rahul/supress-websocket-connection-reattempt
branch
from
3e33487 to
5e5dab1
Compare
We can move this to a debug log, as it is not a critical error.
patnir
force-pushed
the
rahul/supress-websocket-connection-reattempt
branch
from
5e5dab1 to
be662d9
Compare
dguenther
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.