Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates sign command to use ui.ledger for ledger signing #5663

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

hughy
Copy link
Contributor

@hughy hughy commented Nov 19, 2024

Summary

the 'ledger' function from the ui module handles a variety of errors from the ledger app. using the ui function to wrap the app interactions improves user experience over calling the ledger sign method directly

Closes IFL-3149

Testing Plan

  1. create an unsigned transaction from a ledger account using wallet:send --unsignedTransaction
  2. checkout the staging branch
  3. without connecting your ledger, use wallet:transactions:sign to attempt to sign the transaction and observer that the command crashes with an error
image
  1. checkout this branch
  2. repeat step 3 but observe that the command catches the error and instructs you to connect and unlock your ledger
image

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes

the 'ledger' function from the ui module handles a variety of errors from the
ledger app. using the ui function to wrap the app interactions improves user
experience over calling the ledger sign method directly
@hughy hughy requested a review from a team as a code owner November 19, 2024 22:06
@hughy hughy merged commit 22898b6 into staging Nov 19, 2024
14 checks passed
@hughy hughy deleted the feat/hughy/wallet-sign-ledger-ui branch November 19, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants