adds support for fetching account tx by range #5694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds optional startSequence and endSequence request parameters to the 'wallet/getAccountTransactions' RPC to support fetching transactions by a range of block sequences (inclusive) if startSequence is set but not endSequence, then all the maximum 32-bit integer value is used for endSequence if endSequence is set but not startSequence, then the genesis block sequence (1) is used for startSequence
NullSoldier
reviewed
Dec 11, 2024
| request.data.endSequence, | ||
| ) | ||
| } else if (request.data.sequence) { | ||
| transactions = account.getTransactionsBySequence(request.data.sequence) |
There was a problem hiding this comment.
I'm guessing we can just delete this in the future assuming getTransactionsBySequenceRange is inclusive which it looks like it is. Don't do this in this PR, it's just a thought when we start deprecating code in the RPC layer.
There was a problem hiding this comment.
It is inclusive, so we can delete getTransactionsBySequence
NullSoldier
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adds optional startSequence and endSequence request parameters to the 'wallet/getAccountTransactions' RPC to support fetching transactions by a range of block sequences (inclusive)
if startSequence is set but not endSequence, then all the maximum 32-bit integer value is used for endSequence
if endSequence is set but not startSequence, then the genesis block sequence (1) is used for startSequence
Testing Plan
adds unit test
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.