Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix insufficient sh permissions #65

Merged
merged 2 commits into from
Apr 3, 2024
Merged

fix insufficient sh permissions #65

merged 2 commits into from
Apr 3, 2024

Conversation

canxin121
Copy link
Contributor

Origin issue: fzyzcjy/flutter_rust_bridge#1840
Origin pr: fzyzcjy/flutter_rust_bridge#1842

Simple problem description: if you create a new flutter_rust project in windows, the sh script is automatically created, but the executable permissions cannot be set. When moving this project to macOS and executing flutter build ios to build ipa files the process crashes due to insufficient sh script permissions.

This permission problem can be circumvented by sh script.sh rather than script.sh

As verified by Github Action's macOS Runner, the modified cargokit works fine for building ipa apps using the flutter_rust project created on windows.

Action Link

@canxin121
Copy link
Contributor Author

canxin121 commented Mar 28, 2024

Now all tests runs well here: https://github.com/canxin121/todolist/actions/runs/8476136585
I've found that in android builds, run_build_tool.sh seems to be called directly outside of the gradle, and even if you use script.sh in the gradle, it still crashes due to permission issues. So I'm afraid that chmod is the most convenient solution

@canxin121
Copy link
Contributor Author

@knopp Can you take a look at this

@knopp knopp merged commit 969c49a into irondash:main Apr 3, 2024
10 checks passed
@knopp
Copy link
Contributor

knopp commented Apr 3, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants