WIP: Move to dry-rb and remove Virtus #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Need to symbolize keys to make Dry::Struct happy.
* origin/master: Specifying sub-tree for 'comments' is not supported #97 Add attribute context to notification resource #95
forest
commented
Mar 13, 2017
| @@ -285,4 +285,15 @@ def next_page_params | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| require 'faraday_middleware/response_middleware' | |||
| class ParseJsonWithSymbols < FaradayMiddleware::ResponseMiddleware | |||
There was a problem hiding this comment.
Dry::Struct expects keys to be symbols when creating the Dry::Struct based class from a hash (e.g. parsed JSON).
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an exploration of moving away from Virtus. The http://dry-rb.org/ project is a collection of gems that in combination do much of what Virtus does. There are the next generation of Virtus with more general use cases considered and supported.