Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parsing unhandled exceptions #52

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

javiercavlop
Copy link
Collaborator

No description provided.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/main/java/io/github/isagroup/services/parsing/PricingManagerParser.java:362

  • Broadly catching NullPointerException here may obscure underlying issues with missing or malformed add-on data. Consider adding explicit null checks before parsing to better isolate error sources.
} catch (ClassCastException | NullPointerException | IllegalArgumentException e) {

src/main/java/io/github/isagroup/services/parsing/PlanParser.java:199

  • Using a try/catch around planUsageLimitMap.get('value') may mask issues where the map itself is null. It could be clearer to explicitly check for the presence of the key or the map before retrieving its value.
Object value = null;

@javiercavlop javiercavlop requested a review from Alex-GF April 8, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant