Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation class attrs #123

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Annotation class attrs #123

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
25ee8ab
refactor `_parse_scalar` and `_parse_vectorlist`
scottstanie Jun 28, 2023
3cac50a
convert `CalibrationAnnotation` classmethod to return an instance
scottstanie Jun 28, 2023
a847806
convert `NoiseAnnotation.from_et` to return an instance
scottstanie Jun 28, 2023
ee1644c
convert `ProductAnnotation.from_et` to return an instance
scottstanie Jun 28, 2023
a720486
convert `AuxCal` classmethod to return an instance
scottstanie Jun 28, 2023
b997da3
convert `SwathRfiInfo` to return an instance, remove the ipf check fr…
scottstanie Jun 28, 2023
5561be3
remove ipf argument, typo
scottstanie Jun 28, 2023
9e18580
convert the `SwathRfiInfo.extract_by_aztime` to be an instance method
scottstanie Jun 28, 2023
37f0b8c
convert the `parse_vectorlist` to a staticmethod
scottstanie Jun 28, 2023
76f87f9
fix `closest_block_to_azimuth_time` to coerce to numpy array
scottstanie Jun 28, 2023
0ade8d0
two typos
scottstanie Jun 28, 2023
f309b69
Apply suggestions from code review
scottstanie Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
convert the parse_vectorlist to a staticmethod
  • Loading branch information
@scottstanie
scottstanie committed Jun 28, 2023
commit 37f0b8ca287a6528e73bb17147be5b7455bfb8e9
3 changes: 2 additions & 1 deletion src/s1reader/s1_annotation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ class AnnotationBase:
A virtual base class of the inheriting annotation class i.e. Product, Calibration, and Noise.
Not intended for standalone use.
'''

@staticmethod
def _parse_scalar(xml_et: ET.ElementTree, path_field: str, str_type: str):
'''A class method that parse the scalar value in AnnotationBase.xml_et
Expand Down Expand Up @@ -133,7 +134,7 @@ def _parse_scalar(xml_et: ET.ElementTree, path_field: str, str_type: str):

return val_out

@classmethod
@staticmethod
def _parse_vectorlist(xml_et: ET.ElementTree,
name_vector_list: str,
name_vector: str,
Expand Down