Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for "no polynomial" case for azimuth FM rate mitigation & handling the burst without burst polygon #134

Merged

Conversation

seongsujeong
Copy link
Contributor

@seongsujeong seongsujeong commented Sep 12, 2023

This PR is an attempt to fix the rare case that the list pf polynomials (azimuth FM rate or doppler centroid) does not have any overlap with the sensing start / stop of the burst. In that case, the azimuth FM rate mismatch correction finds the nearest polynomials in azimuth time, but the indices for polynomials (index_start and index_end) has the same value. When that happens interpolator from InterpolatedUnivariateSpline cannot be generated.

When that happens, the index_start and index_end are adjusted so that anInterpolatedUnivariateSpline gets to have valid parameters to create the interpolator.
When using the generated interpolator, optional parameter ext=3 was set so that the interpolator returns the values at the left / right boundary values when the input parameter for the interpolation of out of range. This is equivalent to nearest neighbor in this case because the sensing start / stop is "out of range" from the list of polynomials' azimuth time.

Another issue that this PR handles is the when the burst does not have corresponding burst polygon. Such cases have been discovered as documented in #118. When that is the case, s1-reader will fill Sentinel1BurstSlc.border member with empty polygon. Likewise Sentinel1BurstSlc.center will be populated by an empty point geometry.

Seongsu Jeong added 2 commits September 11, 2023 19:01
@seongsujeong seongsujeong changed the title Az fm rate out of range patch WIP: Az fm rate out of range patch Sep 12, 2023
@seongsujeong seongsujeong changed the title WIP: Az fm rate out of range patch WIP: Patch for "no polynomial" case for azimuth FM rate mitigation Sep 12, 2023
@seongsujeong seongsujeong changed the title WIP: Patch for "no polynomial" case for azimuth FM rate mitigation Patch for "no polynomial" case for azimuth FM rate mitigation Sep 19, 2023
@seongsujeong seongsujeong changed the title Patch for "no polynomial" case for azimuth FM rate mitigation Patch for "no polynomial" case for azimuth FM rate mitigation & handling the burst without burst polygon Sep 19, 2023
@seongsujeong
Copy link
Contributor Author

@vbrancat @LiangJYu I think the PR is ready to review. I will submit a PR to COMPASS To change the code accordingly.

Copy link
Contributor

@vbrancat vbrancat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @seongsujeong. We reviewed this PR during our OPERA CSLC tag-up meeting. Please, add comments in the code on which data is affected by this fix. Thank you :)

Copy link
Contributor

@LiangJYu LiangJYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only a nit comment

src/s1reader/s1_burst_slc.py Outdated Show resolved Hide resolved
@seongsujeong seongsujeong merged commit 1b25c05 into isce-framework:main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants