bugfix in Sentinel1BurstSlc.swath_name() #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunjunz
requested review from
scottstanie,
vbrancat,
LiangJYu and
seongsujeong
scottstanie
approved these changes
Dec 2, 2022
seongsujeong
pushed a commit
to seongsujeong/s1-reader
that referenced
this pull request
Feb 17, 2023
seongsujeong
added a commit
that referenced
this pull request
Mar 3, 2023
* Replacing the loaders in Burst* class into class methods, with further implementation for thermal and EAP correction * fix on determining beta_naught; addressing PEP8 issues * Bug fix and feature addition to BurstEAP; restructuring LUT exportation * Readibility improvement; removing unnecessary imports * Format change on `burst_id`; keeping the absolute orbit number inside `Sentinel1BurstSlc` * updates on test_bursts.py * keeping the basename of the CADS and NADS for populating RTC metadata * Update src/s1reader/s1_annotation.py Readability improvement on equation Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Removing commented out code Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Removing the commented out codes Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on code brevity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable for better clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable name for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable name revised for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable renamed for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on docstring Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Readability improvement of equation Co-authored-by: Liang Yu <[email protected]> * addressing comments bt @LiangJYu * docstring fix; variables renamed for clarity * implemented s1_annotation.AucCal.load_from_zip_file() * readability improvement * s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8 compliance * docstring for `s1_burst_slc.eap_compensation_lut()` * class import scheme changed * PEP8 compliance * initial structure of modification * less mod compared to the branch fork * extended coeffs for FM rate and Doppler centroid to be used for azimuth FM mismatch rate mitigation * Working version of azimuth FM rate mismatch mitigation * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * addressing comments from @gshiroma * trailing white spaces are removed * docstring updated * Code cleanup and docstrings * code cleanup * trailing white space removed * docsrting added; variable renaming for less verbosity; * code cleanup and simplification * variable name simplification * clde cleanup * Output as isce3.core.LUT2d * threshold and num_iter for rdr2geo * Addressing codacy issue * Trailing whitespace removed * codacy issue * docstring clarification on `BurstExtendedCoeffs` * whitespace removed * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * comment added for clarity * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * mod on the suggested commit to reuse the topo output filenames * fix on variable * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * typo fix * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Re-using the parsed polynomials; mitigation results as ISCE3 LUT2d * revision on import format * TODO removed * Option to turn on / off the functionalities for az fm rate mismatch mitigation * removing alias for `Rdr2Geo` * whitespace removed after resolving conflict * addressing codacy issue * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_reader.py Co-authored-by: Liang Yu <[email protected]> * variable name changed * bug fixed; variable name updated * addressing codacy issues * codacy issue * variable name changed * pulling out functions that does not need to be methods * whitespace removed * updates after linting * Docstring for `_burst_from_safe_dir` revised * Docstring for `_burst_from_zip` revised * Docstring for `load_bursts` revised * Docstring for `burst_from_xml` revised * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Docstring for `az_fm_rate_mismatch_mitigation` revised * Use temporary directory when `path_scratch` was not provided; take in az/rg steps as options to define radargrid * codacy issue * docstring updated; variable name changed * unnecessary members removed; docstring revised * temporary filename format changed * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * unit_degree -> in_degree * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Apply suggestions from code review Co-authored-by: Scott Staniewicz <[email protected]> * variable name format revised * `mitigate_az_fmrate_mismatch` removed * PEP8 issues * add s1-etad prep module for testing S1-ETAD products (#73) + add s1_etad.py as a wrapper around the `s1etad` module from ESA to read / prepare ETA correction, given a `s1reader` burst object Co-authored-by: Seongsu Jeong <[email protected]> * bugfix in Sentinel1BurstSlc.swath_name() (#89) * s1_reader: fix safe_path for directories (#91) * s1_reader: fix safe_path for directories _burst_from_safe_dir used os.listdir, which does not have "measurement" in the returned names like the zip file list does this fixes #90 * return a string instead of list * Handle the case that the burst's sensing period exceeds the range of `polynomial_list` * azimith to azimuth spelling fix(#93) * Beta release compass (#94) * Replacing the loaders in Burst* class into class methods, with further implementation for thermal and EAP correction * fix on determining beta_naught; addressing PEP8 issues * Bug fix and feature addition to BurstEAP; restructuring LUT exportation * Readibility improvement; removing unnecessary imports * Format change on `burst_id`; keeping the absolute orbit number inside `Sentinel1BurstSlc` * updates on test_bursts.py * keeping the basename of the CADS and NADS for populating RTC metadata * Update src/s1reader/s1_annotation.py Readability improvement on equation Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Removing commented out code Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Removing the commented out codes Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on code brevity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable for better clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable name for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable name revised for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable renamed for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on docstring Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Readability improvement of equation Co-authored-by: Liang Yu <[email protected]> * addressing comments bt @LiangJYu * docstring fix; variables renamed for clarity * implemented s1_annotation.AucCal.load_from_zip_file() * readability improvement * s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8 compliance * docstring for `s1_burst_slc.eap_compensation_lut()` * class import scheme changed * PEP8 compliance * initial structure of modification * less mod compared to the branch fork * extended coeffs for FM rate and Doppler centroid to be used for azimuth FM mismatch rate mitigation * Working version of azimuth FM rate mismatch mitigation * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * addressing comments from @gshiroma * trailing white spaces are removed * docstring updated * Code cleanup and docstrings * code cleanup * trailing white space removed * docsrting added; variable renaming for less verbosity; * code cleanup and simplification * variable name simplification * clde cleanup * Output as isce3.core.LUT2d * threshold and num_iter for rdr2geo * Addressing codacy issue * Trailing whitespace removed * codacy issue * docstring clarification on `BurstExtendedCoeffs` * whitespace removed * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * comment added for clarity * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * mod on the suggested commit to reuse the topo output filenames * fix on variable * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * typo fix * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Re-using the parsed polynomials; mitigation results as ISCE3 LUT2d * revision on import format * TODO removed * Option to turn on / off the functionalities for az fm rate mismatch mitigation * removing alias for `Rdr2Geo` * whitespace removed after resolving conflict * addressing codacy issue * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_reader.py Co-authored-by: Liang Yu <[email protected]> * variable name changed * bug fixed; variable name updated * addressing codacy issues * codacy issue * variable name changed * pulling out functions that does not need to be methods * whitespace removed * updates after linting * Docstring for `_burst_from_safe_dir` revised * Docstring for `_burst_from_zip` revised * Docstring for `load_bursts` revised * Docstring for `burst_from_xml` revised * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Docstring for `az_fm_rate_mismatch_mitigation` revised * Use temporary directory when `path_scratch` was not provided; take in az/rg steps as options to define radargrid * codacy issue * docstring updated; variable name changed * unnecessary members removed; docstring revised * temporary filename format changed * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * unit_degree -> in_degree * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Apply suggestions from code review Co-authored-by: Scott Staniewicz <[email protected]> * variable name format revised * `mitigate_az_fmrate_mismatch` removed * PEP8 issues * Handle the case that the burst's sensing period exceeds the range of `polynomial_list` * version.py updated Co-authored-by: Seongsu Jeong <[email protected]> Co-authored-by: Liang Yu <[email protected]> Co-authored-by: Gustavo H. X. Shiroma <[email protected]> Co-authored-by: vbrancat <[email protected]> Co-authored-by: Scott Staniewicz <[email protected]> * add a --bbox option to s1_info for frame bounds (#88) * add a --bbox option to s1_info for frame bounds * add method to get bounds from the preview, if available * get preview kml bounds working * update usage for bbox and correct entry point * add __init__.py to utils subpackage * try loading any polarization for the bounds, accounting for hh/hv * reorder kml parsing logic * separate options in frame-bbox and burst-bbox * remove unused imports * two-layered calculation of az fm rate mismatch computation * removed trailing whtespaces * whitwspace removed * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * dicstring revised * fix on error string * whitespace removed * docstring revised --------- Co-authored-by: Seongsu Jeong <[email protected]> Co-authored-by: Liang Yu <[email protected]> Co-authored-by: Gustavo H. X. Shiroma <[email protected]> Co-authored-by: vbrancat <[email protected]> Co-authored-by: Scott Staniewicz <[email protected]> Co-authored-by: Zhang Yunjun <[email protected]>
seongsujeong
pushed a commit
to seongsujeong/s1-reader
that referenced
this pull request
Mar 4, 2023
commit 0e0c7816a9b22b057a769519d302cd62e0a4e346 Author: Seongsu Jeong <[email protected]> Date: Fri Mar 3 15:39:13 2023 -0800 Two layered az fm mismatch rate (#101) * Replacing the loaders in Burst* class into class methods, with further implementation for thermal and EAP correction * fix on determining beta_naught; addressing PEP8 issues * Bug fix and feature addition to BurstEAP; restructuring LUT exportation * Readibility improvement; removing unnecessary imports * Format change on `burst_id`; keeping the absolute orbit number inside `Sentinel1BurstSlc` * updates on test_bursts.py * keeping the basename of the CADS and NADS for populating RTC metadata * Update src/s1reader/s1_annotation.py Readability improvement on equation Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Removing commented out code Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Removing the commented out codes Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on code brevity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable for better clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable name for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable name revised for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable renamed for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on docstring Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Readability improvement of equation Co-authored-by: Liang Yu <[email protected]> * addressing comments bt @LiangJYu * docstring fix; variables renamed for clarity * implemented s1_annotation.AucCal.load_from_zip_file() * readability improvement * s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8 compliance * docstring for `s1_burst_slc.eap_compensation_lut()` * class import scheme changed * PEP8 compliance * initial structure of modification * less mod compared to the branch fork * extended coeffs for FM rate and Doppler centroid to be used for azimuth FM mismatch rate mitigation * Working version of azimuth FM rate mismatch mitigation * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * addressing comments from @gshiroma * trailing white spaces are removed * docstring updated * Code cleanup and docstrings * code cleanup * trailing white space removed * docsrting added; variable renaming for less verbosity; * code cleanup and simplification * variable name simplification * clde cleanup * Output as isce3.core.LUT2d * threshold and num_iter for rdr2geo * Addressing codacy issue * Trailing whitespace removed * codacy issue * docstring clarification on `BurstExtendedCoeffs` * whitespace removed * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * comment added for clarity * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * mod on the suggested commit to reuse the topo output filenames * fix on variable * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * typo fix * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Re-using the parsed polynomials; mitigation results as ISCE3 LUT2d * revision on import format * TODO removed * Option to turn on / off the functionalities for az fm rate mismatch mitigation * removing alias for `Rdr2Geo` * whitespace removed after resolving conflict * addressing codacy issue * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_reader.py Co-authored-by: Liang Yu <[email protected]> * variable name changed * bug fixed; variable name updated * addressing codacy issues * codacy issue * variable name changed * pulling out functions that does not need to be methods * whitespace removed * updates after linting * Docstring for `_burst_from_safe_dir` revised * Docstring for `_burst_from_zip` revised * Docstring for `load_bursts` revised * Docstring for `burst_from_xml` revised * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Docstring for `az_fm_rate_mismatch_mitigation` revised * Use temporary directory when `path_scratch` was not provided; take in az/rg steps as options to define radargrid * codacy issue * docstring updated; variable name changed * unnecessary members removed; docstring revised * temporary filename format changed * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * unit_degree -> in_degree * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Apply suggestions from code review Co-authored-by: Scott Staniewicz <[email protected]> * variable name format revised * `mitigate_az_fmrate_mismatch` removed * PEP8 issues * add s1-etad prep module for testing S1-ETAD products (#73) + add s1_etad.py as a wrapper around the `s1etad` module from ESA to read / prepare ETA correction, given a `s1reader` burst object Co-authored-by: Seongsu Jeong <[email protected]> * bugfix in Sentinel1BurstSlc.swath_name() (#89) * s1_reader: fix safe_path for directories (#91) * s1_reader: fix safe_path for directories _burst_from_safe_dir used os.listdir, which does not have "measurement" in the returned names like the zip file list does this fixes #90 * return a string instead of list * Handle the case that the burst's sensing period exceeds the range of `polynomial_list` * azimith to azimuth spelling fix(#93) * Beta release compass (#94) * Replacing the loaders in Burst* class into class methods, with further implementation for thermal and EAP correction * fix on determining beta_naught; addressing PEP8 issues * Bug fix and feature addition to BurstEAP; restructuring LUT exportation * Readibility improvement; removing unnecessary imports * Format change on `burst_id`; keeping the absolute orbit number inside `Sentinel1BurstSlc` * updates on test_bursts.py * keeping the basename of the CADS and NADS for populating RTC metadata * Update src/s1reader/s1_annotation.py Readability improvement on equation Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Removing commented out code Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Removing the commented out codes Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on code brevity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable for better clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable name for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable name revised for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable renamed for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on docstring Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Readability improvement of equation Co-authored-by: Liang Yu <[email protected]> * addressing comments bt @LiangJYu * docstring fix; variables renamed for clarity * implemented s1_annotation.AucCal.load_from_zip_file() * readability improvement * s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8 compliance * docstring for `s1_burst_slc.eap_compensation_lut()` * class import scheme changed * PEP8 compliance * initial structure of modification * less mod compared to the branch fork * extended coeffs for FM rate and Doppler centroid to be used for azimuth FM mismatch rate mitigation * Working version of azimuth FM rate mismatch mitigation * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * addressing comments from @gshiroma * trailing white spaces are removed * docstring updated * Code cleanup and docstrings * code cleanup * trailing white space removed * docsrting added; variable renaming for less verbosity; * code cleanup and simplification * variable name simplification * clde cleanup * Output as isce3.core.LUT2d * threshold and num_iter for rdr2geo * Addressing codacy issue * Trailing whitespace removed * codacy issue * docstring clarification on `BurstExtendedCoeffs` * whitespace removed * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * comment added for clarity * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * mod on the suggested commit to reuse the topo output filenames * fix on variable * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * typo fix * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Re-using the parsed polynomials; mitigation results as ISCE3 LUT2d * revision on import format * TODO removed * Option to turn on / off the functionalities for az fm rate mismatch mitigation * removing alias for `Rdr2Geo` * whitespace removed after resolving conflict * addressing codacy issue * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_reader.py Co-authored-by: Liang Yu <[email protected]> * variable name changed * bug fixed; variable name updated * addressing codacy issues * codacy issue * variable name changed * pulling out functions that does not need to be methods * whitespace removed * updates after linting * Docstring for `_burst_from_safe_dir` revised * Docstring for `_burst_from_zip` revised * Docstring for `load_bursts` revised * Docstring for `burst_from_xml` revised * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Docstring for `az_fm_rate_mismatch_mitigation` revised * Use temporary directory when `path_scratch` was not provided; take in az/rg steps as options to define radargrid * codacy issue * docstring updated; variable name changed * unnecessary members removed; docstring revised * temporary filename format changed * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * unit_degree -> in_degree * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Apply suggestions from code review Co-authored-by: Scott Staniewicz <[email protected]> * variable name format revised * `mitigate_az_fmrate_mismatch` removed * PEP8 issues * Handle the case that the burst's sensing period exceeds the range of `polynomial_list` * version.py updated Co-authored-by: Seongsu Jeong <[email protected]> Co-authored-by: Liang Yu <[email protected]> Co-authored-by: Gustavo H. X. Shiroma <[email protected]> Co-authored-by: vbrancat <[email protected]> Co-authored-by: Scott Staniewicz <[email protected]> * add a --bbox option to s1_info for frame bounds (#88) * add a --bbox option to s1_info for frame bounds * add method to get bounds from the preview, if available * get preview kml bounds working * update usage for bbox and correct entry point * add __init__.py to utils subpackage * try loading any polarization for the bounds, accounting for hh/hv * reorder kml parsing logic * separate options in frame-bbox and burst-bbox * remove unused imports * two-layered calculation of az fm rate mismatch computation * removed trailing whtespaces * whitwspace removed * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * dicstring revised * fix on error string * whitespace removed * docstring revised --------- Co-authored-by: Seongsu Jeong <[email protected]> Co-authored-by: Liang Yu <[email protected]> Co-authored-by: Gustavo H. X. Shiroma <[email protected]> Co-authored-by: vbrancat <[email protected]> Co-authored-by: Scott Staniewicz <[email protected]> Co-authored-by: Zhang Yunjun <[email protected]> commit 53f0c4373fac371e55d7baa09f95bcc0ea186fbd Author: Scott Staniewicz <[email protected]> Date: Tue Feb 21 16:46:28 2023 -0500 allow az_step/rg_step arguments to `as_isce3_radargrid` (#102) * allow az_step/rg_step arguments to `as_isce3_radargrid` This allows a more coarse radar grid, as needed by some lookup tables such as the SET correction * Apply PRF suggestions from code review Co-authored-by: Heresh Fattahi <[email protected]> * adjust length/width based on az_step/rg_step * fix the logic for width/length calculation with rg/az_step * reversed order of length/width * add two tests for as_isce3_radar_grid fixed the division to make the tests pass * add clarification to docstring about sensing start --------- Co-authored-by: Heresh Fattahi <[email protected]> commit 2b43f2fb593658175e6e5a4bf8d3ee548c4770e9 Author: Scott Staniewicz <[email protected]> Date: Mon Feb 13 14:56:58 2023 -0500 s1_orbit.py: if autodownloading, create the directory (#100) * s1_orbit.py: if autodownloading, create the directory There shouldnt be a need to have the user `mkdir -p orbits/` if they have already specified they do not have the orbits and want to download them. * add print to log directory creation commit 428328de5011968da91174cdf14db6eb3e8264c7 Author: Scott Staniewicz <[email protected]> Date: Thu Dec 22 15:10:07 2022 -0500 add a --bbox option to s1_info for frame bounds (#88) * add a --bbox option to s1_info for frame bounds * add method to get bounds from the preview, if available * get preview kml bounds working * update usage for bbox and correct entry point * add __init__.py to utils subpackage * try loading any polarization for the bounds, accounting for hh/hv * reorder kml parsing logic * separate options in frame-bbox and burst-bbox * remove unused imports commit a29a422b60bc02341d85a1a78b42657d5bea5576 Author: Seongsu Jeong <[email protected]> Date: Wed Dec 21 14:14:04 2022 -0800 Beta release compass (#94) * Replacing the loaders in Burst* class into class methods, with further implementation for thermal and EAP correction * fix on determining beta_naught; addressing PEP8 issues * Bug fix and feature addition to BurstEAP; restructuring LUT exportation * Readibility improvement; removing unnecessary imports * Format change on `burst_id`; keeping the absolute orbit number inside `Sentinel1BurstSlc` * updates on test_bursts.py * keeping the basename of the CADS and NADS for populating RTC metadata * Update src/s1reader/s1_annotation.py Readability improvement on equation Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Removing commented out code Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Removing the commented out codes Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on code brevity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable for better clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable name for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable name revised for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable renamed for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on docstring Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Readability improvement of equation Co-authored-by: Liang Yu <[email protected]> * addressing comments bt @LiangJYu * docstring fix; variables renamed for clarity * implemented s1_annotation.AucCal.load_from_zip_file() * readability improvement * s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8 compliance * docstring for `s1_burst_slc.eap_compensation_lut()` * class import scheme changed * PEP8 compliance * initial structure of modification * less mod compared to the branch fork * extended coeffs for FM rate and Doppler centroid to be used for azimuth FM mismatch rate mitigation * Working version of azimuth FM rate mismatch mitigation * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * addressing comments from @gshiroma * trailing white spaces are removed * docstring updated * Code cleanup and docstrings * code cleanup * trailing white space removed * docsrting added; variable renaming for less verbosity; * code cleanup and simplification * variable name simplification * clde cleanup * Output as isce3.core.LUT2d * threshold and num_iter for rdr2geo * Addressing codacy issue * Trailing whitespace removed * codacy issue * docstring clarification on `BurstExtendedCoeffs` * whitespace removed * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * comment added for clarity * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * mod on the suggested commit to reuse the topo output filenames * fix on variable * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * typo fix * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Re-using the parsed polynomials; mitigation results as ISCE3 LUT2d * revision on import format * TODO removed * Option to turn on / off the functionalities for az fm rate mismatch mitigation * removing alias for `Rdr2Geo` * whitespace removed after resolving conflict * addressing codacy issue * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_reader.py Co-authored-by: Liang Yu <[email protected]> * variable name changed * bug fixed; variable name updated * addressing codacy issues * codacy issue * variable name changed * pulling out functions that does not need to be methods * whitespace removed * updates after linting * Docstring for `_burst_from_safe_dir` revised * Docstring for `_burst_from_zip` revised * Docstring for `load_bursts` revised * Docstring for `burst_from_xml` revised * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Docstring for `az_fm_rate_mismatch_mitigation` revised * Use temporary directory when `path_scratch` was not provided; take in az/rg steps as options to define radargrid * codacy issue * docstring updated; variable name changed * unnecessary members removed; docstring revised * temporary filename format changed * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * unit_degree -> in_degree * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Apply suggestions from code review Co-authored-by: Scott Staniewicz <[email protected]> * variable name format revised * `mitigate_az_fmrate_mismatch` removed * PEP8 issues * Handle the case that the burst's sensing period exceeds the range of `polynomial_list` * version.py updated Co-authored-by: Seongsu Jeong <[email protected]> Co-authored-by: Liang Yu <[email protected]> Co-authored-by: Gustavo H. X. Shiroma <[email protected]> Co-authored-by: vbrancat <[email protected]> Co-authored-by: Scott Staniewicz <[email protected]> commit 10fe381efec12fe4660da7edcc0bf14fbfd3982a Author: Liang Yu <[email protected]> Date: Tue Dec 20 16:31:55 2022 -0800 azimith to azimuth spelling fix(#93) commit eb5e53e8a530dd1e2bc4b9acc82f5a3932ec92cf Author: Seongsu Jeong <[email protected]> Date: Thu Dec 15 15:23:05 2022 -0800 FM rate mismatch - follow-up bug fix (#92) * Replacing the loaders in Burst* class into class methods, with further implementation for thermal and EAP correction * fix on determining beta_naught; addressing PEP8 issues * Bug fix and feature addition to BurstEAP; restructuring LUT exportation * Readibility improvement; removing unnecessary imports * Format change on `burst_id`; keeping the absolute orbit number inside `Sentinel1BurstSlc` * updates on test_bursts.py * keeping the basename of the CADS and NADS for populating RTC metadata * Update src/s1reader/s1_annotation.py Readability improvement on equation Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Removing commented out code Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Removing the commented out codes Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on code brevity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable for better clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable name for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable name revised for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable renamed for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on docstring Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Readability improvement of equation Co-authored-by: Liang Yu <[email protected]> * addressing comments bt @LiangJYu * docstring fix; variables renamed for clarity * implemented s1_annotation.AucCal.load_from_zip_file() * readability improvement * s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8 compliance * docstring for `s1_burst_slc.eap_compensation_lut()` * class import scheme changed * PEP8 compliance * initial structure of modification * less mod compared to the branch fork * extended coeffs for FM rate and Doppler centroid to be used for azimuth FM mismatch rate mitigation * Working version of azimuth FM rate mismatch mitigation * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * addressing comments from @gshiroma * trailing white spaces are removed * docstring updated * Code cleanup and docstrings * code cleanup * trailing white space removed * docsrting added; variable renaming for less verbosity; * code cleanup and simplification * variable name simplification * clde cleanup * Output as isce3.core.LUT2d * threshold and num_iter for rdr2geo * Addressing codacy issue * Trailing whitespace removed * codacy issue * docstring clarification on `BurstExtendedCoeffs` * whitespace removed * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * comment added for clarity * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * mod on the suggested commit to reuse the topo output filenames * fix on variable * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * typo fix * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Re-using the parsed polynomials; mitigation results as ISCE3 LUT2d * revision on import format * TODO removed * Option to turn on / off the functionalities for az fm rate mismatch mitigation * removing alias for `Rdr2Geo` * whitespace removed after resolving conflict * addressing codacy issue * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_reader.py Co-authored-by: Liang Yu <[email protected]> * variable name changed * bug fixed; variable name updated * addressing codacy issues * codacy issue * variable name changed * pulling out functions that does not need to be methods * whitespace removed * updates after linting * Docstring for `_burst_from_safe_dir` revised * Docstring for `_burst_from_zip` revised * Docstring for `load_bursts` revised * Docstring for `burst_from_xml` revised * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Docstring for `az_fm_rate_mismatch_mitigation` revised * Use temporary directory when `path_scratch` was not provided; take in az/rg steps as options to define radargrid * codacy issue * docstring updated; variable name changed * unnecessary members removed; docstring revised * temporary filename format changed * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * unit_degree -> in_degree * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Apply suggestions from code review Co-authored-by: Scott Staniewicz <[email protected]> * variable name format revised * `mitigate_az_fmrate_mismatch` removed * PEP8 issues * Handle the case that the burst's sensing period exceeds the range of `polynomial_list` Co-authored-by: Seongsu Jeong <[email protected]> Co-authored-by: Liang Yu <[email protected]> Co-authored-by: Gustavo H. X. Shiroma <[email protected]> Co-authored-by: vbrancat <[email protected]> Co-authored-by: Scott Staniewicz <[email protected]> commit e1cbc573c89df647f8c5831fcfa3c70b55c087cf Author: Seongsu Jeong <[email protected]> Date: Tue Dec 13 13:13:29 2022 -0800 Azimuth FM rate mismatch mitigation (#80) * Replacing the loaders in Burst* class into class methods, with further implementation for thermal and EAP correction * fix on determining beta_naught; addressing PEP8 issues * Bug fix and feature addition to BurstEAP; restructuring LUT exportation * Readibility improvement; removing unnecessary imports * Format change on `burst_id`; keeping the absolute orbit number inside `Sentinel1BurstSlc` * updates on test_bursts.py * keeping the basename of the CADS and NADS for populating RTC metadata * Update src/s1reader/s1_annotation.py Readability improvement on equation Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Removing commented out code Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Reverting the docstring to be split into two lines for PEP8 compliance Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Improving docstring of the code copied from isce2 Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Removing the commented out codes Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on code brevity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable for better clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py renaming variable name for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable name revised for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py variable renamed for clarity Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py improvement on docstring Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Readability improvement of equation Co-authored-by: Liang Yu <[email protected]> * addressing comments bt @LiangJYu * docstring fix; variables renamed for clarity * implemented s1_annotation.AucCal.load_from_zip_file() * readability improvement * s1_annotation.py - code cleanup; excention handling for AUX_CAL; PEP8 compliance * docstring for `s1_burst_slc.eap_compensation_lut()` * class import scheme changed * PEP8 compliance * initial structure of modification * less mod compared to the branch fork * extended coeffs for FM rate and Doppler centroid to be used for azimuth FM mismatch rate mitigation * Working version of azimuth FM rate mismatch mitigation * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: Gustavo H. X. Shiroma <[email protected]> * addressing comments from @gshiroma * trailing white spaces are removed * docstring updated * Code cleanup and docstrings * code cleanup * trailing white space removed * docsrting added; variable renaming for less verbosity; * code cleanup and simplification * variable name simplification * clde cleanup * Output as isce3.core.LUT2d * threshold and num_iter for rdr2geo * Addressing codacy issue * Trailing whitespace removed * codacy issue * docstring clarification on `BurstExtendedCoeffs` * whitespace removed * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_orbit.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * comment added for clarity * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * mod on the suggested commit to reuse the topo output filenames * fix on variable * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * typo fix * Update src/s1reader/s1_burst_slc.py Co-authored-by: vbrancat <[email protected]> * Re-using the parsed polynomials; mitigation results as ISCE3 LUT2d * revision on import format * TODO removed * Option to turn on / off the functionalities for az fm rate mismatch mitigation * removing alias for `Rdr2Geo` * whitespace removed after resolving conflict * addressing codacy issue * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Update src/s1reader/s1_reader.py Co-authored-by: Liang Yu <[email protected]> * variable name changed * bug fixed; variable name updated * addressing codacy issues * codacy issue * variable name changed * pulling out functions that does not need to be methods * whitespace removed * updates after linting * Docstring for `_burst_from_safe_dir` revised * Docstring for `_burst_from_zip` revised * Docstring for `load_bursts` revised * Docstring for `burst_from_xml` revised * Update src/s1reader/s1_burst_slc.py Co-authored-by: Liang Yu <[email protected]> * Docstring for `az_fm_rate_mismatch_mitigation` revised * Use temporary directory when `path_scratch` was not provided; take in az/rg steps as options to define radargrid * codacy issue * docstring updated; variable name changed * unnecessary members removed; docstring revised * temporary filename format changed * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_annotation.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * unit_degree -> in_degree * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Update src/s1reader/s1_burst_slc.py Co-authored-by: Scott Staniewicz <[email protected]> * Apply suggestions from code review Co-authored-by: Scott Staniewicz <[email protected]> * variable name format revised * `mitigate_az_fmrate_mismatch` removed * PEP8 issues Co-authored-by: Seongsu Jeong <[email protected]> Co-authored-by: Liang Yu <[email protected]> Co-authored-by: Gustavo H. X. Shiroma <[email protected]> Co-authored-by: vbrancat <[email protected]> Co-authored-by: Scott Staniewicz <[email protected]> commit ae88a1d56df19b8e1cd5f8be9bc73e195e256c31 Author: Scott Staniewicz <[email protected]> Date: Wed Dec 7 11:35:15 2022 -0500 s1_reader: fix safe_path for directories (#91) * s1_reader: fix safe_path for directories _burst_from_safe_dir used os.listdir, which does not have "measurement" in the returned names like the zip file list does this fixes #90 * return a string instead of list commit a9c20a42f038e2f8b65ea7c1cf2f4719a1ce49c7 Author: Zhang Yunjun <[email protected]> Date: Thu Dec 1 20:45:08 2022 -0800 bugfix in Sentinel1BurstSlc.swath_name() (#89) commit dfc028a2d6848c693c74aca95351c798cd4e6686 Author: Zhang Yunjun <[email protected]> Date: Thu Dec 1 17:00:13 2022 -0800 add s1-etad prep module for testing S1-ETAD products (#73) + add s1_etad.py as a wrapper around the `s1etad` module from ESA to read / prepare ETA correction, given a `s1reader` burst object Co-authored-by: Seongsu Jeong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in
s1_burst_slc.Sentinel1BurstSlc.swath_name()introduced in #77. This fix is required to run opera-adt/opera-notebooks#1.