Add Catalog completeness #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Bootstrap Progress Bar Import * Add Progress Bar and Quality Icon
* Add french translation * Add english translation
* Add $completeness to Product Entity * Add $completeness_quality to Product Entity
* Create product insight entity * Create insights field in Product Entity
This command updates all the actual Products and create the insights when completeness is not full. This also add completeness bar.
Add quality check for description
* Add hasProductInsights
* Create ProductInsightManager * Add progress bar
* Update FillCompletenessCommand * Update Relatoins between Product & Insights * Add Design to the edit page
ncharlot
reviewed
Dec 3, 2018
| } | ||
|
|
||
| $product->setCompleteness($completeness); | ||
| $completeness = 8; |
| $ids = $productManager->findAllId(); | ||
| $completeness = 8; | ||
| foreach ($ids as $id) { | ||
| $product = $productManager->findOneBy(["id" => $id[0]['id']]); |
There was a problem hiding this comment.
Don't repeat yourself: this code seems to be duplicated from createProductInsights().
Why don't you call this method?
| <div class="alert alert-warning row" role="alert"> | ||
| <div class="col-md-6"> | ||
| {% for insight in insights %} | ||
| {% if insight.getCode() == 4 %} |
| $product = $productManager->createForProducer($producer); | ||
|
|
||
| $form = $this->getForm($product); | ||
| if ($request->isMethod('POST')) { | ||
| $form->handleRequest($request); | ||
| if ($form->isValid()) { | ||
| $productInsightsManager->createProductInsight($product); |
There was a problem hiding this comment.
I would be smarter to use Doctrine Events to add this behavior.
Use PSR-2 condition style
Fix two space indentation by replacing with a four space indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add catalog completeness through UI notifications on the dashboard.
(SendMail command is not finished)