Remove set_reg and get_reg out of rmi's interface #233
+135
−155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `set_reg` was used to sidestep the dependency issue between monitor and armv9a. Now that the dependency issue has been resolved, it doesn't have to be inside the list of RMI's Interface.
Previously, `get_reg` was used to sidestep the dependency issue between monitor and armv9a. Now that the dependency issue has been resolved, it doesn't have to be inside the list of RMI's Interface.
zpzigi754
force-pushed
the
rm-set-regs
branch
from
78a0829 to
7bc203c
Compare
zpzigi754
requested review from
bitboom,
nook1208,
bokdeuk-jeong and
hihi-wang
hihi-wang
approved these changes
Nov 9, 2023
|
Thanks! |
bitboom
approved these changes
Nov 27, 2023
bokdeuk-jeong
approved these changes
Nov 27, 2023
|
I will make a new PR removing all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains refactoring commits related to #231. Previously,
set_regandget_regwere used to sidestep the dependency issue between monitor and armv9a. Now that the dependency issue has been resolved by the integration, they don't have to be inside the list of RMI's Interface.