Fixes for physical joystick (ONVIF)- issue #189 #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes for physical joystick (ONVIF)- issue ispysoftware#189 1. Fix bug - pt did not receive a s stop command; Activate stop command on joystick release; (physical joystick got defined as DigitalPTZ for some reason) changed internal bool DigitalPTZ => PTZSettings == null; to internal bool DigitalPTZ = false; 2. Feature: Change pan & tilt speed in correlation with joystick position; used tanh function for more sensitive transformation of joystick position to pan/tilt speed;
ispysoftware
requested changes
May 16, 2022
fix bug - physical ptz missing stop command, without break of digital PTZ internal bool DigitalPTZ => _cameraControl.Camobject.ptz == -1;
ispysoftware
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for physical joystick (ONVIF)- issue #189
Fix bug - pt did not receive a s stop command;
Activate stop command on joystick release; (physical joystick got defined as DigitalPTZ for some reason)
changed internal bool DigitalPTZ => PTZSettings == null;
to
internal bool DigitalPTZ = false;
Feature:
Change pan & tilt speed in correlation with joystick position;
used tanh function for more sensitive transformation of joystick position to pan/tilt speed;