Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset variable backend API with dynamic paths #55

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

israelias
Copy link
Owner

@israelias israelias commented Jan 11, 2025

This pull request includes changes to the frontend/src/constants/backend.constants.ts file to improve the configuration and resource management. The most important changes include updating the backend URL configuration and modifying the way static assets are referenced.

Configuration updates:

  • Changed the BACKEND_URL to use an environment variable with a fallback to a local server URL.
  • Updated the API constant to dynamically use the BACKEND_URL.

Resource management improvements:

  • Modified the references to static assets (DEFAULT_AVATAR, DEFAULT_PLACEHOLDER, MOBILE_SPLASHSCREEN, DEFAULT_ICON, DEFAULT_ADAPTIVE_ICON) to use local assets with a fallback to URLs based on the BACKEND_URL.This pull request to frontend/src/constants/backend.constants.ts includes changes to improve the configuration of backend URLs and asset paths. The most important changes include updating the backend URL configuration to be dynamic and replacing hardcoded asset paths with local asset references.

Configuration updates:

Asset path updates:

Copy link

vercel bot commented Jan 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
django-react-ecommerce-7jin ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 4:41am
thrifthub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 4:41am
thrifthub-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 4:41am

@vercel vercel bot temporarily deployed to Preview – thrifthub-frontend January 11, 2025 04:37 Inactive
@vercel vercel bot temporarily deployed to Preview – django-react-ecommerce-7jin January 11, 2025 04:37 Inactive
@vercel vercel bot temporarily deployed to Preview – django-react-ecommerce-7jin January 11, 2025 04:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thrifthub-frontend January 11, 2025 04:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant