-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PlatformIO and some refactors #12
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
This reverts commit 8f58dc1.
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Signed-off-by: Jose Vega <[email protected]>
Sorry, I forget extract in other branch the code refactors, even so I did testing and commit each little change for avoid broke nothing. The main reason of this refactors is separate responsibilities in different modules, making this great project more testable and robust, so that will be more easy add new features. |
Hi, thanks for your work. It is nice to see other people collaborating. |
I'll look at a way to make it compatible with both environments. in my case when l tried platformIO didn't feel like back to arduino. |
Hack for can works with Arduino IDE and PlatformIO at the same time Also documented Signed-off-by: Jose Vega <[email protected]>
Great. I will take a look asap |
Sorry, still no time. |
Don't worry friend, that's things happen to everybody. Trust me, I prefer that you take it with calm because you better understand the changes that I propose you. Now I am doing a few changes to the PCB for achieve works with a NodeMCU board (I have many of this boards forgotten in a drawer 😄 ). I will make a pcb piece when I end the changes to continue playing with the project. |
Hi, Is is possible to get finished pcb? |
Hi @snetekombinerke , if you are interested in my version for wemos d1 mini write me at [email protected] for more details about getting the pcb. If it is the nodeMCU, just contact jvegaf. |
@issalig @snetekombinerke just I released the esp32 pcb version 😁 https://github.com/jvegaf/toshiba_air_cond/releases/tag/esp32_v1 |
Nice! @jvegaf, BTW I wrote you an email to your gmail some weeks ago, not sure if you got it. |
Is josevega234 correct? it is where I sent it. |
I sended you a email to your mejijof at getnada dot com account |
Ok. Got it. |
I replied your mail 😊 |
Hi, I've sent you an email 30. avg., 21:39. Please check. |
Yes gmail dot com
El sáb, 27 ago 2022, 12:51, issalig ***@***.***> escribió:
… Is josevega234 correct? it is where I sent it.
—
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIGROWBWW636QAC4LBCA33V3HXKBANCNFSM5SKBCWYA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @jvegaf, was just wondering how far did you get this? I was looking out for solutions for our Toshiba air conditioner units and stumbled across this project |
Hi,
I've migrated the Arduino project to PlatformIO because its more feats like:
test with my nodemcu board is working perfect 😄
Coming soon will like send a some PR with more little refactors
Regards