Skip to content
This repository has been archived by the owner on Jan 23, 2022. It is now read-only.

Perform preemption check only when used as a chained plugin #256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

luksa
Copy link
Contributor

@luksa luksa commented Feb 26, 2020

When Istio CNI is not used as a chained plugin, throwing an
error or logging the preemption warning doesn't make sense.
For example, when using Multus CNI, multiple CNI config
files are in the same dir, but none of them has precedence
over the others, as they are loaded by name. In that case,
logging the warning isn't appropriate.

When Istio CNI is not used as a chained plugin, throwing an
error or logging the preemption warning doesn't make sense.
For example, when using Multus CNI, multiple CNI config
files are in the same dir, but none of them has precedence
over the others, as they are loaded by name. In that case,
logging the warning isn't appropriate.
@luksa luksa requested a review from a team as a code owner February 26, 2020 14:02
@istio-policy-bot
Copy link

😊 Welcome @luksa! This is either your first contribution to the Istio cni repo, or it's been awhile since
you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 26, 2020
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 26, 2020
@istio-testing
Copy link
Contributor

Hi @luksa. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jwendell jwendell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Feb 26, 2020
@jwendell jwendell added the cherrypick/release-1.5 Set this label on a PR to auto-merge it to the release-1.5 branch label Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherrypick/release-1.5 Set this label on a PR to auto-merge it to the release-1.5 branch cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants