Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add istio_feature.proto for feature https://docs.google.com/document/… #541

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

add istio_feature.proto for feature https://docs.google.com/document/… #541

wants to merge 3 commits into from

Conversation

zhlsunshine
Copy link

According to proposal design doc, add proto file for Istio feature management.

@zhlsunshine zhlsunshine requested a review from a team as a code owner March 3, 2022 05:59
@zhlsunshine zhlsunshine added the release-notes-none Indicates a PR that does not require release notes. label Mar 3, 2022
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2022
@zhlsunshine zhlsunshine mentioned this pull request Mar 3, 2022
Open
jacob-delgado
jacob-delgado reviewed Mar 14, 2022
View reviewed changes
common-protos/istio.io/extensions/istio_feature.proto Outdated
@@ -0,0 +1,48 @@
// Copyright 2019 Istio Authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The year no longer gets included.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, removed

jacob-delgado
jacob-delgado reviewed Mar 14, 2022
View reviewed changes
Copy link
Contributor

@jacob-delgado jacob-delgado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like there should be a job in test-infra to update this proto when istio/api is updated. I understand that PR is still in-flight. Should the generated proto also be included?

@zhlsunshine
Copy link
Author

I feel like there should be a job in test-infra to update this proto when istio/api is updated. I understand that PR is still in-flight. Should the generated proto also be included?

Yes, agree, test-infra should aware it if istio/api has any change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob-delgado jacob-delgado jacob-delgado left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release-notes-none Indicates a PR that does not require release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhlsunshine @jacob-delgado @istio-testing