Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the openshift profile is deprecated in favor of setting the openshift platform #16051

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Using the openshift profile is deprecated in favor of setting the openshift platform #16051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions content/en/docs/setup/platform-setup/openshift/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ test: no

Follow these instructions to prepare an OpenShift cluster for Istio.

Install Istio using the OpenShift profile:
Install Istio using the OpenShift platform profile:

{{< text bash >}}
$ istioctl install --set profile=openshift
$ istioctl install --set values.global.platform=openshift
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bleggett, this command does not enable CNI which is required for OpenShift. Please see...

$: istioctl install --set values.global.platform=openshift
        |\          
        | \         
        |  \        
        |   \       
      /||    \      
     / ||     \     
    /  ||      \    
   /   ||       \   
  /    ||        \  
 /     ||         \ 
/______||__________\
____________________
  \__       _____/  
     \_____/        

This will install the Istio 1.24.0 profile "default" into the cluster. Proceed? (y/N) y
✔ Istio core installed ⛵️                                                                                                                                                                     
✔ Istiod installed 🧠                                                                                                                                                                         
✔ Ingress gateways installed 🛬                                                                                                                                                               
✔ Installation complete 

$: k get pods -n kube-system
NAME                       READY   STATUS    RESTARTS   AGE
coredns-58696f69f5-ndwkq   1/1     Running   0          98d

OTOH, if we use the openshift profile...

$: istioctl install --set profile=openshift
        |\          
        | \         
        |  \        
        |   \       
      /||    \      
     / ||     \     
    /  ||      \    
   /   ||       \   
  /    ||        \  
 /     ||         \ 
/______||__________\
____________________
  \__       _____/  
     \_____/        

This will install the Istio 1.24.0 profile "openshift" into the cluster. Proceed? (y/N) y
✔ Istio core installed ⛵️                                                                                                                                                                     
✔ Istiod installed 🧠                                                                                                                                                                         
✔ Ingress gateways installed 🛬                                                                                                                                                               
✔ CNI installed 🪢                                                                                                                                                                            
✔ Installation complete    

$: k get pods -n kube-system
NAME                       READY   STATUS    RESTARTS   AGE
coredns-58696f69f5-ndwkq   1/1     Running   0          98d
istio-cni-node-4s7vj       1/1     Running   0          36s
istio-cni-node-78jhz       1/1     Running   0          36s
istio-cni-node-9klq6       1/1     Running   0          36s
istio-cni-node-lff9v       1/1     Running   0          36s
istio-cni-node-wkdm7       1/1     Running   0          36s
istio-cni-node-xpbnz       1/1     Running   0          36s
$

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to modify the command as follows

istioctl install --set components.cni.enabled=true --set components.cni.namespace=kube-system --set values.global.platform=openshift

Copy link
Contributor Author

@bleggett bleggett Dec 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll have to modify the command as follows

istioctl install --set components.cni.enabled=true --set components.cni.namespace=kube-system --set values.global.platform=openshift

Yeah - ideally (since we don't use Helm wrapper charts to conditionally select components) platform and profile should be purely Helm overrides, and istioctl should infer what components to choose based on the value of platform. Right now it's kind of all over the place, and we have two different kinds of profile that have different effects, depending on the install method, and then platform which is shared across both.

That just confuses people.

Lemme see if I can improve this.

{{< /text >}}

After installation is complete, expose an OpenShift route for the ingress gateway.
Expand Down
2 changes: 1 addition & 1 deletion content/uk/docs/setup/platform-setup/openshift/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ test: no
Встановіть Istio, використовуючи профіль OpenShift:

{{< text bash >}}
$ istioctl install --set profile=openshift
$ istioctl install --set values.global.platform=openshift
{{< /text >}}

Після завершення встановлення, створіть маршрут OpenShift для ingress gateway:
Expand Down
2 changes: 1 addition & 1 deletion content/zh/docs/setup/platform-setup/openshift/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ test: no
使用 OpenShift 配置文件进行安装 Istio：

{{< text bash >}}
$ istioctl install --set profile=openshift
$ istioctl install --set values.global.platform=openshift
{{< /text >}}

安装 Istio 完成后，通过以下命令为 Ingress Gateway 暴露 OpenShift 路由：
Expand Down