-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation on how to run the Istio-proxy as a container on VM's instead of the istio-proxy runtime(rpm/deb) #16217
base: master
Are you sure you want to change the base?
Conversation
Some documentation on how someone could run the Istio proxy as a container on their preferred VM platform. - A users can iterate on the existing VM documentation (and is required to understand it.) - The use is responsible for automation around it.
|
😊 Welcome! This is either your first contribution to the Istio documentation repo, or
Thanks for contributing! Courtesy of your friendly welcome wagon. |
Hi @KristiaanHoogendoorn. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
.spelling
Outdated
@@ -456,6 +456,7 @@ DNS | |||
DNS_AUTO_ALLOCATE | |||
docker-compose's | |||
docker.io | |||
Podman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failing test due to not being sorted properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be fixed
- docker | ||
- containers | ||
owner: istio/wg-environments-maintainers | ||
test: yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless you're writing a test for this page - which would be great if you could - you don't need this set.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Craig thanks for checking. Are there docs available to get me started? I might be able to setup something similar to the VM setup with docker in docker but have to see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea how we would go about testing something involving a VM. Have a look to see if we have any kind of testing for the existing VM docs?
1512d6b
to
9bbf9cd
Compare
Description
Some documentation on how someone could run the Istio proxy as a container on their preferred VM platform.
Disclaimer, sorry for possible bad spelling but I'm dyslectic and probably have missed some/ created some weird sentences.
Overall feedback is very welcome.
Reviewers