adjust metrics content-type #1361
Open
+75
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pt header Signed-off-by: ilrudie <[email protected]>
|
😊 Welcome @ilrudie! This is either your first contribution to the Istio ztunnel repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
the
size/S
howardjohn
reviewed
Nov 8, 2024
src/metrics/server.rs
Outdated
| .to_lowercase() | ||
| .split(";") | ||
| .collect::<Vec<_>>() | ||
| .first() |
There was a problem hiding this comment.
Do we know that prometheus will always scrape with openmetrics as the first 'accept'
There was a problem hiding this comment.
Good point, that is likely not a safe invariant
There was a problem hiding this comment.
Finally got back around to this. Got it reworked to support multiple Accept headers and added testing.
istio-testing
added
size/M
Signed-off-by: ilrudie <[email protected]>
ilrudie
force-pushed
the
better-serve-metrics
branch
from
26f0653
to
c70f5ee
Compare
Signed-off-by: ilrudie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly serve metrics with text/plain unless given an openmetrics Accept header
fixes #1356