h2: poll ready before using #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is "required" per the docs. I don't think it really is, but good to be safe and follow the docs
howardjohn
added
release-notes-none
istio-testing
added
the
size/XS
bleggett
approved these changes
May 1, 2024
bleggett
reviewed
May 1, 2024
| @@ -258,6 +258,9 @@ impl H2ConnectClient { | |||
| &mut self, | |||
| req: Request<()>, | |||
| ) -> Result<(SendStream<SendBuf>, h2::RecvStream), Error> { | |||
| // "This function must return `Ready` before `send_request` is called" | |||
| // We should always be ready though, because we make sure we don't go over the max stream limit out of band. | |||
There was a problem hiding this comment.
Yeah I saw this in the docs at some point but didn't check if we were doing this in the DIY client.
Better to be correct.
|
/retest flake is fixed in another pr |
|
/retest |
|
In response to a cherrypick label: #997 failed to apply on top of branch "release-1.22": |
|
In response to a cherrypick label: new issue created for failed cherrypick: #999 |
howardjohn
added a commit
to howardjohn/ztunnel
that referenced
this pull request
May 2, 2024
This is "required" per the docs. I don't think it really is, but good to be safe and follow the docs (cherry picked from commit faa4f23)
istio-testing
pushed a commit
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is "required" per the docs. I don't think it really is, but good to
be safe and follow the docs