Fix bug with validation for SchedulesEvents #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ssashaa
requested review from
DmitryTkachenko,
DevPew01,
BobTheSuperman,
apyura,
PavelTsyposhchuk,
BohdanZaliubovskyi,
da-real-ivanpan and
andy-dendy-repo
PavelTsyposhchuk
approved these changes
May 17, 2022
Comment on lines
62
to
75
| { | ||
| if (await _unitOfWork.ScheduledEventRepository.IsLessonConnectedToSheduledEventAsync(lessonId)) | ||
| string errorMsg = await _validator.ValidateConnectEventToLessonAsync(eventId, lessonId); | ||
|
|
||
| if (!string.IsNullOrEmpty(errorMsg)) | ||
| { | ||
| return Result<ScheduledEventDTO>.GetError(ErrorCode.Conflict, $"Lesson with id={lessonId} is already associated with another ScheduledEvent"); | ||
| throw new EntityValidationException(errorMsg); | ||
| } | ||
|
|
||
| var scheduleEntity = await _unitOfWork.ScheduledEventRepository.ConnectEventToLessonByIdAsync(eventId, lessonId); | ||
|
|
||
| return scheduleEntity == null ? | ||
| Result<ScheduledEventDTO>.GetError(ErrorCode.NotFound, $"Scheduled event with id={eventId} does not exist") : | ||
| Result<ScheduledEventDTO>.GetSuccess(_mapper.Map<ScheduledEventDTO>(scheduleEntity)); | ||
| return Result<ScheduledEventDTO>.GetSuccess(_mapper.Map<ScheduledEventDTO>(scheduleEntity)); | ||
| } | ||
|
|
||
| public async Task<Result<SingleEventDTO>> CreateSingleEventAsync(CreateSingleEventDto createSingleEvent) |
There was a problem hiding this comment.
It may be better to use Result instead of throwing an exception, u sure that we need to throw an exception? It`s an additional performance issue, logging this exception and other effects
DevPew01
approved these changes
May 20, 2022
# Conflicts: # CharlieBackend.Business/Helpers/ResponseMessages.cs # CharlieBackend.Business/Services/ScheduleServiceFolder/EventsService.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.