Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1022 Homepage view #1026

Merged
merged 2 commits into from
Feb 25, 2025
Merged

1022 Homepage view #1026

merged 2 commits into from
Feb 25, 2025

Conversation

DanielVajnagi
Copy link
Contributor

@DanielVajnagi DanielVajnagi commented Feb 13, 2025

Not Final, still needs text from customer

Code reviewers

Second Level Review

Summary of issue

Changes in home page view

Summary of change

In the middle of the main page instead of "Welcome to the diaper calculator" there should be "Welcome to the ZeroWaste calculator" "Вас вітає ZeroWaste калькулятор"

Under the welcoming, the text should be divided into 2 blocks for two calculators

image

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (2e994f7) to head (551a488).
Report is 30 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1026   +/-   ##
========================================
  Coverage    98.71%   98.71%           
========================================
  Files           71       71           
  Lines         1011     1011           
========================================
  Hits           998      998           
  Misses          13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielVajnagi DanielVajnagi linked an issue Feb 13, 2025 that may be closed by this pull request
@DanielVajnagi DanielVajnagi self-assigned this Feb 20, 2025
@loqimean loqimean merged commit 87a93a7 into develop Feb 25, 2025
5 checks passed
@loqimean loqimean deleted the 1022-homepage-view branch February 25, 2025 16:22
@DanielVajnagi DanielVajnagi restored the 1022-homepage-view branch February 25, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MHC] Home page view
2 participants