Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map properties in custom namespace to ACLs and File ID #15468

Merged
merged 79 commits into from
Apr 3, 2024
Merged

Map properties in custom namespace to ACLs and File ID #15468

merged 79 commits into from
Apr 3, 2024

Conversation

chenkins
Copy link
Collaborator

No description provided.

@chenkins chenkins requested a review from a team as a code owner December 14, 2023 21:09
@chenkins chenkins marked this pull request as draft December 14, 2023 21:09
@chenkins chenkins self-assigned this Dec 14, 2023
@dkocher dkocher added the ctera label Dec 15, 2023
@dkocher dkocher requested a review from ylangisc December 18, 2023 07:49
@chenkins chenkins force-pushed the feature/CTERA-136 branch 3 times, most recently from a84a17a to 6a36272 Compare December 20, 2023 08:09
dkocher
dkocher requested changes Dec 28, 2023
View reviewed changes
ctera/src/main/java/ch/cyberduck/core/ctera/CteraAclPermissionFeature.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraAclPermissionFeature.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraSession.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraSession.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraSession.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraSession.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraSession.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraSession.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraSession.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraSession.java Outdated Show resolved Hide resolved
dkocher
dkocher requested changes Jan 3, 2024
View reviewed changes
ctera/src/main/java/ch/cyberduck/core/ctera/CteraCopyFeature.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraDeleteFeature.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraListService.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraReadFeature.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraWriteFeature.java Outdated Show resolved Hide resolved
ctera/src/test/java/ch/cyberduck/core/ctera/CteraPermissionFeatureAclToPermissionTest.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraAclPermissionFeature.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraReadFeature.java Outdated Show resolved Hide resolved
@dkocher dkocher changed the title Map custom XML fields to Acl and Permission in Ctera session (CTERA-136) Map custom XML fields to ACLs and Permissions (CTERA-136) Jan 8, 2024
@chenkins chenkins changed the title Map custom XML fields to ACLs and Permissions (CTERA-136) Map custom XML fields to ACLs and Permissions/Custom XML fields to distinguish between renamed data and new data (CTERA-136/CTERA-137) Jan 9, 2024
@dkocher dkocher added this to the 8.7.3 milestone Jan 11, 2024
@dkocher dkocher removed this from the 8.8.0 milestone Mar 5, 2024
@chenkins chenkins force-pushed the feature/CTERA-136 branch from 28e6002 to 942edd4 Compare March 18, 2024 16:01
dkocher
dkocher requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@dkocher dkocher left a comment •
edited by chenkins
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Resolve all TODOs
  • Omit redundant ctera prefix in method names

ctera/src/main/java/ch/cyberduck/core/ctera/CteraAttributesFinderFeature.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraAclPermissionFeature.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraAclPermissionFeature.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraAclPermissionFeature.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraListService.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraSession.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraSession.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraSession.java Outdated Show resolved Hide resolved
ctera/src/main/java/ch/cyberduck/core/ctera/CteraMoveFeature.java Show resolved Hide resolved
ctera/src/test/java/ch/cyberduck/core/ctera/CteraAttributesFinderFeatureTest.java Show resolved Hide resolved
@dkocher dkocher force-pushed the feature/CTERA-136 branch from ebf69b0 to 4c4b161 Compare March 26, 2024 15:05
@chenkins chenkins requested a review from dkocher March 26, 2024 19:06
@chenkins chenkins requested a review from dkocher March 27, 2024 21:19
@dkocher dkocher enabled auto-merge (squash) March 28, 2024 07:29
@chenkins chenkins requested a review from ylangisc April 2, 2024 19:56
@chenkins chenkins requested a review from dkocher April 3, 2024 10:30
@dkocher dkocher added this to the 8.8.2 milestone Apr 3, 2024
dkocher
dkocher approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@dkocher dkocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tests

@dkocher dkocher merged commit 7615468 into master Apr 3, 2024
6 checks passed
@dkocher dkocher deleted the feature/CTERA-136 branch April 3, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkocher dkocher dkocher approved these changes

@ylangisc ylangisc Awaiting requested review from ylangisc

Assignees

@chenkins chenkins

Labels
ctera
Projects
None yet
Milestone
8.8.2
Development

Successfully merging this pull request may close these issues.
3 participants
@chenkins @dkocher @ylangisc