Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index: fetch: validate localfs meta using md5 #507

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Feb 15, 2024

Ugly hack for local storages. Pretty much only affects local imports in certain cases, which is not super common.

Related iterative/dvc#10270

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (05afa6f) 63.08% compared to head (6826db4) 63.03%.

Files Patch % Lines
src/dvc_data/index/fetch.py 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   63.08%   63.03%   -0.05%     
==========================================
  Files          62       62              
  Lines        4321     4326       +5     
  Branches      731      732       +1     
==========================================
+ Hits         2726     2727       +1     
- Misses       1439     1443       +4     
  Partials      156      156              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@efiop efiop marked this pull request as ready for review February 15, 2024 15:19
@efiop efiop merged commit 5fb53c7 into iterative:main Feb 15, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants