Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvclive: copy best lightning checkpoint #4768

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

dberenbaum
Copy link
Contributor

@dberenbaum dberenbaum requested a review from daavoo August 16, 2023 16:04
Comment on lines -69 to +74
- if `log_model == 'all'`, checkpoints are logged during training.
- if `log_model == False` (default), no checkpoint is logged.

- if `log_model == True`, checkpoints are logged at the end of training,
except when `save_top_k == -1` which also logs every checkpoint during
training.
except when `save_top_k == -1` which logs every checkpoint during training.

- if `log_model == False` (default), no checkpoint is logged.
- if `log_model == 'all'`, checkpoints are logged during training.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but felt like the current order didn't make sense.

@shcheklein shcheklein temporarily deployed to dvc-org-lightning-log-m-pm2ti4 August 16, 2023 16:08 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2023

Link Check Report

There were no links to check!

@daavoo daavoo merged commit 607c534 into main Aug 16, 2023
@daavoo daavoo deleted the lightning-log-model-update branch August 16, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants