-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fetch/push/status: not handling config from other revisions #9754
Labels
A: data-sync
Related to dvc get/fetch/import/pull/push
bug
Did we break something?
p2-medium
Medium priority, should be done, but less important
Comments
efiop
added
bug
Did we break something?
A: data-sync
Related to dvc get/fetch/import/pull/push
labels
Jul 24, 2023
efiop
added a commit
to efiop/dvc
that referenced
this issue
Jul 24, 2023
Config is a more immutable thing and using `repo` is confusing and might be error prone in the bigger picture. Related to iterative#9754
efiop
added a commit
to efiop/dvc
that referenced
this issue
Jul 24, 2023
Config is a more immutable thing and using `repo` is confusing and might be error prone in the bigger picture. Related to iterative#9754
efiop
added a commit
to efiop/dvc
that referenced
this issue
Jul 24, 2023
Config is a more immutable thing and using `repo` is confusing and might be error prone in the bigger picture. Related to iterative#9754
efiop
added a commit
to efiop/dvc
that referenced
this issue
Jul 24, 2023
Config is a more immutable thing and using `repo` is confusing and might be error prone in the bigger picture. Related to iterative#9754
efiop
added a commit
to efiop/dvc
that referenced
this issue
Jul 24, 2023
Config is a more immutable thing and using `repo` is confusing and might be error prone in the bigger picture. Related to iterative#9754
efiop
added a commit
that referenced
this issue
Jul 24, 2023
Config is a more immutable thing and using `repo` is confusing and might be error prone in the bigger picture. Related to #9754
efiop
added a commit
to efiop/dvc
that referenced
this issue
Jul 25, 2023
Related iterative#9754 and fixes `dvc fetch`.
Do we respect any of the per-revision remote config? Or we always use the remote config from the workspace? |
@dberenbaum Always using the remote config from the workspace. Not respecting per-revision remote configs at all 🙁 Now fixed for |
dberenbaum
added
the
p2-medium
Medium priority, should be done, but less important
label
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A: data-sync
Related to dvc get/fetch/import/pull/push
bug
Did we break something?
p2-medium
Medium priority, should be done, but less important
When branches have wildly different remote setups, those configs are not taken into account during fetch/push/status -c --all-tags/branches/etc
Example:
Studio uses real
git checkout
to collect objects and has been doing that for years as a workaround, but I couldn't find an issue in dvc yet.To fix this we should make
config
part ofIndex
(same as stages, outs, etc are, don't confuse with DataIndex) and use it to buildIndex.data
. This is the easiest to do indvc fetch
because it is usingIndex.data
already, but might require temporary workarounds forpush/status -c
like manually triggering config reloading in brancher or something.The text was updated successfully, but these errors were encountered: