repo: brancher/switch: reset parsed fields #9758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related iterative#9754 and fixes `dvc fetch`.
3 tasks
efiop
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9758 +/- ##
==========================================
+ Coverage 90.46% 90.48% +0.01%
==========================================
Files 480 480
Lines 36588 36586 -2
Branches 5263 5265 +2
==========================================
+ Hits 33101 33104 +3
+ Misses 2889 2886 -3
+ Partials 598 596 -2
☔ View full report in Codecov by Sentry. |
efiop
commented
Jul 25, 2023
Comment on lines
104
to
+106
| self.root_dir = saved_root | ||
| self.dvc_dir = saved_dvc_dir | ||
| self._reset() # pylint: disable=protected-access |
There was a problem hiding this comment.
Clunky and brancher should go away in favor of switch/etc, but this will do for now.
efiop
commented
Jul 25, 2023
| @@ -203,7 +203,8 @@ def test_verify_hashes(tmp_dir, scm, dvc, mocker, tmp_path_factory, local_remote | |||
| # Removing cache will invalidate existing state entries | |||
| dvc.cache.local.clear() | |||
|
|
|||
| dvc.config["remote"]["upstream"]["verify"] = True | |||
There was a problem hiding this comment.
In-memory changes to config can't work between command sessions, the logic is really the same as with us resetting index, because other commands/instances could modify the config while we are not holding a lock. Same in changed tests below.
efiop
added a commit
to efiop/dvc
that referenced
this pull request
Aug 10, 2023
This used to work like so but by accident, when we didn't reload config at all when collecting other revisions. Regression from iterative#9758
efiop
added a commit
that referenced
this pull request
Aug 10, 2023
This used to work like so but by accident, when we didn't reload config at all when collecting other revisions. Regression from #9758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #9754 and fixes
dvc fetch.