Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc: add --skip-failed #10155

Merged
merged 2 commits into from
Dec 19, 2023
Merged

gc: add --skip-failed #10155

merged 2 commits into from
Dec 19, 2023

Conversation

dberenbaum
Copy link
Collaborator

Closes #5037. Follows up on the great work started by @courentin in #5038. Also related to #9768 (comment).

Example:

$ dvc gc -A --skip-failed
WARNING: This will remove all cache except items used in the workspace and all git commits of the current repo.
Are you sure you want to proceed? [y/n]: y
WARNING: Failed to collect 'workspace', skipping
WARNING: Failed to collect '964799719df645d5104c541410549f702d2a9b5d', skipping
WARNING: Failed to collect '9c24c7652c3eb28adaa2caafdff7dfdc21f1e449', skipping
WARNING: Failed to collect '616500724541bcd2f7f89584187b00f838ecf9a9', skipping
No unused 'repo' cache to remove.
No unused 'local' cache to remove.
No unused 'legacy' cache to remove.

@dberenbaum dberenbaum requested a review from a team December 11, 2023 23:20
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (77b451d) 90.63% compared to head (78b02b8) 90.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10155      +/-   ##
==========================================
- Coverage   90.63%   90.40%   -0.23%     
==========================================
  Files         496      496              
  Lines       37751    37769      +18     
  Branches     5490     5493       +3     
==========================================
- Hits        34215    34145      -70     
- Misses       2900     2967      +67     
- Partials      636      657      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dberenbaum dberenbaum self-assigned this Dec 12, 2023
@Danila89
Copy link

It looks like ready to be merged, doesn't it?)

@efiop efiop merged commit 457d615 into main Dec 19, 2023
24 checks passed
@efiop efiop deleted the gc-skip-failed branch December 19, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add ability to skip "dirty" commits during dvc gc
3 participants