fix partial fetch #10205
Merged
fix partial fetch #10205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
added
p1-important
Closes iterative#10199. Bumps dvc-data to >=3.4.
skshetry
force-pushed
the
fix-partial-fetch
branch
from
10946c9
to
64649b4
Compare
efiop
approved these changes
Dec 27, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10205 +/- ##
=======================================
Coverage 90.54% 90.54%
=======================================
Files 499 499
Lines 37950 37953 +3
Branches 5514 5517 +3
=======================================
+ Hits 34363 34366 +3
Misses 2943 2943
Partials 644 644 ☔ View full report in Codecov by Sentry. |
BradyJ27
pushed a commit
to BradyJ27/dvc
that referenced
this pull request
Apr 22, 2024
Closes iterative#10199. Bumps dvc-data to >=3.4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10199. Bumps dvc-data to >=3.4.
In the tests, I have increased the number of files to 10s of files, so that it raises an alarm when the
fetchedstat is much larger in case of partial pull.