studio: add subdir to live metrics post messages to support live experiments in monorepos #10303
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10303 +/- ##
=======================================
Coverage 90.58% 90.59%
=======================================
Files 493 493
Lines 37757 37774 +17
Branches 5454 5460 +6
=======================================
+ Hits 34204 34221 +17
Misses 2919 2919
Partials 634 634 ☔ View full report in Codecov by Sentry. |
| @@ -351,16 +350,6 @@ def fs(self, fs: "FileSystem"): | |||
| # fs. | |||
| self._reset() | |||
|
|
|||
| @property | |||
| def subrepo_relpath(self) -> str: | |||
There was a problem hiding this comment.
[F] kept this the same as in #10291 because it doesn't fit nicely on Repo
mattseddon
force-pushed
the
add-live-subdir
branch
2 times, most recently
from
c9049c5
to
2fe3b62
Compare
|
Currently needs a Studio release |
|
@dberenbaum can you PTAL at this now Studio has been released |
mattseddon
force-pushed
the
add-live-subdir
branch
from
2fe3b62
to
943ed24
Compare
|
Should we add a test to https://github.com/iterative/dvc/blob/main/tests/integration/test_studio_live_experiments.py to ensure the subdir is sent to studio? |
mattseddon
force-pushed
the
add-live-subdir
branch
from
943ed24
to
ddc048e
Compare
I felt like the complexity that needed to be tested was addressed by |
mattseddon
force-pushed
the
add-live-subdir
branch
2 times, most recently
from
5a62b93
to
ce61b84
Compare
…riments in monorepos
mattseddon
force-pushed
the
add-live-subdir
branch
from
ce61b84
to
687b06d
Compare
| name = dvc.experiments.get_exact_name([exp_rev])[exp_rev] | ||
|
|
||
| name = project_a_dvc.experiments.get_exact_name([exp_rev])[exp_rev] | ||
| project_a_dvc.close() |
There was a problem hiding this comment.
Note to self: without calling close on the repo test_build_full_outs will fail when tmp is True. Example here.
…riments in monorepos (iterative#10303)
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Part of https://github.com/iterative/studio/issues/8848
Depends on iterative/dvc-studio-client#154 / https://github.com/iterative/studio/pull/9173
Required by iterative/dvclive#787
Repeat of #10291 but stripped back to only send subdir.