push: use index push #9807
Merged
push: use index push #9807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
efiop
force-pushed
the
index-push
branch
2 times, most recently
from
b657943
to
8cc8d25
Compare
efiop
force-pushed
the
index-push
branch
2 times, most recently
from
7e526c6
to
6a810ff
Compare
Codecov ReportAttention:
... and 30 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
efiop
force-pushed
the
index-push
branch
8 times, most recently
from
fca283f
to
fd87ebb
Compare
efiop
force-pushed
the
index-push
branch
4 times, most recently
from
7b0cb7e
to
b2419b1
Compare
efiop
force-pushed
the
index-push
branch
4 times, most recently
from
705616a
to
ea3dfba
Compare
efiop
added a commit
to efiop/dvc-data
that referenced
this pull request
Oct 24, 2023
Leftover from some old attempts. Related iterative/dvc#9807
efiop
force-pushed
the
index-push
branch
10 times, most recently
from
a7b437b
to
a9ca9a7
Compare
efiop
commented
Oct 25, 2023
| @@ -486,7 +486,7 @@ def test_pull_partial(tmp_dir, dvc, local_remote): | |||
| clean(["foo"], dvc) | |||
|
|
|||
| stats = dvc.pull(os.path.join("foo", "bar")) | |||
| assert stats["fetched"] == 3 | |||
| assert stats["fetched"] == 2 | |||
There was a problem hiding this comment.
We were pulling redundant files here.
efiop
commented
Oct 25, 2023
| @@ -182,7 +182,7 @@ def test_partial_checkout_and_update(M, tmp_dir, dvc, remote): | |||
|
|
|||
| assert dvc.pull("dir/subdir") == M.dict( | |||
| added=[join("dir", "")], | |||
| fetched=3, | |||
| fetched=2, | |||
There was a problem hiding this comment.
Also were pulling redundant files here.
efiop
commented
Oct 25, 2023
| @@ -148,7 +148,7 @@ def test_hash_recalculation(mocker, dvc, tmp_dir, local_remote): | |||
| assert ret == 0 | |||
| ret = main(["push"]) | |||
| assert ret == 0 | |||
| assert test_file_md5.mock.call_count == 1 | |||
| assert test_file_md5.mock.call_count == 3 | |||
There was a problem hiding this comment.
2 new are from in-memfs calc for dirs.
efiop
force-pushed
the
index-push
branch
2 times, most recently
from
9d860c0
to
07e2393
Compare
This was referenced Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9333