Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove support for dvc machine #9837

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Aug 11, 2023

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Closes #9792

Since we are not using dvc machine we can just drop it from DVC for now so we don't have to maintain dead code and so we can remove the dependency on TPI/terraform

  • Removes dvc.machine
  • Removes dvc.repo.experiments.executor.ssh

@pmrowla pmrowla self-assigned this Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.40% 🎉

Comparison is base (bee04c6) 90.41% compared to head (f685785) 90.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9837      +/-   ##
==========================================
+ Coverage   90.41%   90.81%   +0.40%     
==========================================
  Files         484      473      -11     
  Lines       36915    35982     -933     
  Branches     5330     5189     -141     
==========================================
- Hits        33375    32678     -697     
+ Misses       2930     2713     -217     
+ Partials      610      591      -19     
Files Changed Coverage Δ
dvc/cli/parser.py 100.00% <ø> (ø)
dvc/commands/experiments/run.py 100.00% <ø> (ø)
dvc/repo/__init__.py 94.94% <ø> (+0.42%) ⬆️
dvc/repo/experiments/__init__.py 79.20% <ø> (-0.10%) ⬇️
tests/unit/command/test_experiments.py 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmrowla pmrowla merged commit a051b8b into iterative:main Aug 11, 2023
20 checks passed
@pmrowla pmrowla deleted the drop-machine branch August 11, 2023 05:42
@skshetry
Copy link
Member

skshetry commented Aug 11, 2023

Thanks @pmrowla. I think we can also remove ./tests/remotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

drop dvc.machine and tpi/python-terraform dependency
2 participants