Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve bounding box frontend components #5305

Closed
wants to merge 32 commits into from
Closed

Improve bounding box frontend components #5305

wants to merge 32 commits into from

Commits on Jan 26, 2024

  1. move classes into its own collapsible row

    @julieg18
    julieg18 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    d32537c View commit details
    Browse the repository at this point in the history

  2. keep the same classnames for cells

    @julieg18
    julieg18 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    f6fb6c2 View commit details
    Browse the repository at this point in the history

  3. Store bounding box plot coordinates in single obj

    @julieg18
    julieg18 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    169384b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'bounding-boxes' into stop-passing-bb-coords-as-props

    @julieg18
    julieg18 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    91c905e View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. first iteration of backend code addition

    @julieg18
    julieg18 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    9045ab0 View commit details
    Browse the repository at this point in the history

  2. Remove frontend bounding box fixture code

    @julieg18
    julieg18 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    1e76753 View commit details
    Browse the repository at this point in the history

  3. fix bug in bb fixture

    @julieg18
    julieg18 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    2c85d58 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. fix bug in tests

    @julieg18
    julieg18 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ef0b553 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'bounding-boxes' into stop-passing-bb-coords-as-props

    @julieg18
    julieg18 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    0692a99 View commit details
    Browse the repository at this point in the history

  3. fix merge conflicts

    @julieg18
    julieg18 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    8cace73 View commit details
    Browse the repository at this point in the history

  4. fix typo

    @julieg18
    julieg18 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ba4bdd0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'stop-passing-bb-coords-as-props' into add-bb-backend-logic

    @julieg18
    julieg18 committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    b1abf5d View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. add toggle comparison class logic and additional tests

    @julieg18
    julieg18 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    dd431e1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'bounding-boxes' into add-bb-backend-logic

    @julieg18
    julieg18 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    d240272 View commit details
    Browse the repository at this point in the history

  3. final lookover

    @julieg18
    julieg18 committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    4da57cb View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Update coordinate system

    @julieg18
    julieg18 committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    d09e5f0 View commit details
    Browse the repository at this point in the history

  2. apply review comments

    @julieg18
    julieg18 committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    646306a View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. update schema

    @julieg18
    julieg18 committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    86767f6 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Merge branch 'bounding-boxes' into add-bb-backend-logic

    @julieg18
    julieg18 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    7fce713 View commit details
    Browse the repository at this point in the history

  2. move colors and use var when collecting plot class details

    @julieg18
    julieg18 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    0176f1a View commit details
    Browse the repository at this point in the history

  3. rely on collected comparison plots when grabbing selected class boxes

    @julieg18
    julieg18 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    ff95253 View commit details
    Browse the repository at this point in the history

  4. add additional optimisation

    @julieg18
    julieg18 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    c6e59f0 View commit details
    Browse the repository at this point in the history

  5. fix typo

    @julieg18
    julieg18 committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    06b6f5b View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. first iteration

    @julieg18
    julieg18 committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    9535cd3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add-bb-backend-logic' into improve-bounding-box-frontend

    @julieg18
    julieg18 committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    7dc8696 View commit details
    Browse the repository at this point in the history

  3. add show more logic and tests

    @julieg18
    julieg18 committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    681f914 View commit details
    Browse the repository at this point in the history

  4. fix bug

    @julieg18
    julieg18 committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    00ab35b View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2024

  1. Fix slice typo

    @julieg18
    julieg18 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    56873dc View commit details
    Browse the repository at this point in the history

  2. Next iteration based on review

    @julieg18
    julieg18 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    3af7101 View commit details
    Browse the repository at this point in the history

  3. improve storybook and remove onclick

    @julieg18
    julieg18 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    dc9cb8a View commit details
    Browse the repository at this point in the history

  4. Merge branch 'bounding-boxes' into improve-bounding-box-frontend

    @julieg18
    julieg18 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    729067e View commit details
    Browse the repository at this point in the history

  5. Merge branch 'bounding-boxes' into improve-bounding-box-frontend

    @julieg18
    julieg18 committed Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f2f082f View commit details
    Browse the repository at this point in the history