Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 6.4/api platform 3.33 #124

Merged

Conversation

Mr-Martin-Kristiansen
Copy link
Contributor

@Mr-Martin-Kristiansen Mr-Martin-Kristiansen commented Aug 5, 2024

Link to ticket

https://leantime.itkdev.dk/dashboard/home#/tickets/showTicket/1884

Description

Update apiplatform to latest version

Screenshot of the result

Checklist

  • [x ] My code is covered by test cases.
  • [ x] My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

There is a potential problem with DateTimeZone.

@Mr-Martin-Kristiansen
Copy link
Contributor Author

there should be an errorhandler that tells if non non env file is set for DateTimeZone.

Copy link
Contributor

@jekuaitk jekuaitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mr-Martin-Kristiansen Mr-Martin-Kristiansen merged commit bcb9f8e into book-286/update_to_3.0 Aug 8, 2024
8 checks passed
@Mr-Martin-Kristiansen Mr-Martin-Kristiansen deleted the symfony_6.4/api_platform_3.33 branch August 8, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants