Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build assets task #430

Merged
merged 4 commits into from
Jan 14, 2025
Merged

add build assets task #430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f03a3b
add build assets task
sinejespersen Jan 14, 2025
122a535
changelog
sinejespersen Jan 14, 2025
23d7797
move documentation from testing to localdevelopment
sinejespersen Jan 14, 2025
332aa1d
rename task and moved assets build
sinejespersen Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ Versioning](https://semver.org/spec/v2.0.0.html).

## [Unreleased]

* [PR-430](https://github.com/itk-dev/hoeringsportal/pull/430)
Add build assets to taskfile
* [PR-429](https://github.com/itk-dev/hoeringsportal/pull/429)
Removed outdated (and unused) API endpoints. Cleaned up.
* [PR-427](https://github.com/itk-dev/hoeringsportal/pull/427)
Expand Down
5 changes: 5 additions & 0 deletions Taskfile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ tasks:
- task compose-up
- task composer-install
- task drush -- --yes site:install --existing-config
- task assets-build
- task site-open
- task site-open-admin
silent: true
Expand Down Expand Up @@ -56,6 +57,10 @@ tasks:
sh: task drush -- user:login --no-browser
silent: true

assets-build:
cmds:
- '{{.DOCKER_COMPOSE}} run --rm node yarn --cwd web/themes/custom/hoeringsportal install'
- '{{.DOCKER_COMPOSE}} run --rm node yarn --cwd web/themes/custom/hoeringsportal build'
compose:
cmds:
- '{{.DOCKER_COMPOSE}} --profile pretix {{.CLI_ARGS}}'
Expand Down
4 changes: 0 additions & 4 deletions documentation/Testing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ docker compose exec phpfpm vendor/bin/drush sql:query "DELETE FROM locales_targe
docker compose exec phpfpm vendor/bin/drush state:delete citizen_proposal_admin_form_values --yes
docker compose exec phpfpm vendor/bin/drush cache:rebuild

# Build theme assets
docker compose run --rm node yarn --cwd web/themes/custom/hoeringsportal install
docker compose run --rm node yarn --cwd web/themes/custom/hoeringsportal build

# Optional, but recommended for proper testing
# docker compose exec phpfpm vendor/bin/drush site:install --existing-config --yes

Expand Down
4 changes: 4 additions & 0 deletions documentation/localDevelopment.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ docker compose up --detach
docker compose exec phpfpm composer install
docker compose exec phpfpm vendor/bin/drush --yes site:install --existing-config

# Build theme assets
docker compose run --rm node yarn --cwd web/themes/custom/hoeringsportal install
docker compose run --rm node yarn --cwd web/themes/custom/hoeringsportal build

# Get admin sign in url
docker compose exec phpfpm vendor/bin/drush --yes --uri="http://hoeringsportal.local.itkdev.dk" user:login
```
Expand Down
Loading