Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUPP0RT-1235: Added submission helper command #218

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

SUPP0RT-1235: Added submission helper command #218

wants to merge 1 commit into from

Conversation

rimi-itk
Copy link
Contributor

@rimi-itk rimi-itk commented Sep 21, 2023 •
edited
Loading

https://jira.itkdev.dk/browse/SUPP0RT-1235

Adds convenient submission helper command.

Note: All failed checks are related to the booking module.

@rimi-itk rimi-itk force-pushed the hotfix/SUPP0RT-1235-submission-on-wrong-webform branch from 33e4e70 to 84a904a Compare September 21, 2023 13:11
@rimi-itk rimi-itk marked this pull request as ready for review September 21, 2023 13:20
@rimi-itk rimi-itk requested a review from jekuaitk September 21, 2023 13:21
@rimi-itk rimi-itk changed the base branch from main to develop October 12, 2023 08:32
@rimi-itk rimi-itk changed the base branch from develop to main October 12, 2023 08:33
@rimi-itk rimi-itk force-pushed the hotfix/SUPP0RT-1235-submission-on-wrong-webform branch from 84a904a to 8b67550 Compare October 12, 2023 09:04
@rimi-itk rimi-itk changed the base branch from main to develop October 12, 2023 09:04
@rimi-itk rimi-itk force-pushed the hotfix/SUPP0RT-1235-submission-on-wrong-webform branch from 8b67550 to 346e743 Compare October 12, 2023 09:05
@rimi-itk rimi-itk requested a review from jekuaitk October 12, 2023 09:05
jekuaitk
jekuaitk approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@jekuaitk jekuaitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one clarification/idea.

web/modules/custom/os2forms_selvbetjening/src/Command/WebformSubmissionCommands.php Outdated Show resolved Hide resolved
@rimi-itk rimi-itk force-pushed the hotfix/SUPP0RT-1235-submission-on-wrong-webform branch from 346e743 to 1bfbdcb Compare October 13, 2023 08:53
@rimi-itk rimi-itk requested a review from jekuaitk October 13, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jekuaitk jekuaitk jekuaitk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rimi-itk @jekuaitk