Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1039: Added Maestro notification pdf template #291

Closed
wants to merge 8 commits into from

Conversation

jekuaitk
Copy link
Contributor

@jekuaitk jekuaitk commented Mar 27, 2024

https://leantime.itkdev.dk/?tab=ticketdetails#/tickets/showTicket/1039

Depends on OS2Forms/os2forms#95

  • Added templates for os2forms_attachment and maestro pdf notifications, which can be used to have a common styling between the two.

Notification before
Screenshot 2024-03-27 at 09 38 18

Notification after (and with the configuration changes)
Screenshot 2024-04-02 at 09 30 51

@jekuaitk jekuaitk force-pushed the feature/1039-flows-pdf-styling branch from ab085ed to 19384a4 Compare March 27, 2024 12:54
@jekuaitk jekuaitk requested a review from rimi-itk March 27, 2024 13:08
CHANGELOG.md Outdated Show resolved Hide resolved
Comment on lines +27 to +28
and disable default css in the entity print module. This is done by
unchecking `Enable Default CSS` on `admin/config/content/entityprint`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be done in our exported config (in config/sync).

Comment on lines +11 to +16
The maestro notification pdf template should be configured on
`admin/config/system/os2forms_forloeb` as

```sh
themes/custom/os2forms_selvbetjening_theme/templates/pdf/os2forms-selvbetjening-maestro-notification-pdf-html.html.twig
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must be done in our exported config (in config/sync).

@jekuaitk jekuaitk marked this pull request as draft March 27, 2024 14:27
@jekuaitk
Copy link
Contributor Author

Moved to #315

@jekuaitk jekuaitk closed this May 14, 2024
@jekuaitk jekuaitk deleted the feature/1039-flows-pdf-styling branch May 14, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants