oembed: add __oembedError to enable optional meta fallbacks

itteco · Nov 1, 2024 · 7aa1084 · 7aa1084
1 parent f93d596
commit 7aa1084
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/plugins/system/oembed/oembed.js b/lib/plugins/system/oembed/oembed.js
@@ -129,14 +129,19 @@ export default {
 
             if (error && !oembed) {
                 return cb('Oembed error "'+ oembedLinks[0].href + '": ' + error, {
-                    oembedError: error
+                    oembedError: error,
+                    __oembedError: error // To enable fallbacks to optional meta
                 });
             } else if (error && oembed) { // via  `options.parseErrorBody = true`
                 return cb(null, {
                     oembedError: {
                         code: error, 
                         body: oembed
-                    }
+                    },
+                    __oembedError: { // To enable fallbacks to optional meta
+                        code: error, 
+                        body: oembed
+                    },
                 });
             }
 

diff --git a/plugins/domains/soundcloud.com/soundcloud-oembed-error.js b/plugins/domains/soundcloud.com/soundcloud-oembed-error.js
@@ -2,7 +2,8 @@ export default {
 
     provides: ['__allow_soundcloud_meta', 'iframe'],
 
-    getData: function(oembedError, twitter, options, plugins, cb) {
+    getData: function(__oembedError, twitter, options, plugins, cb) {
+        var oembedError = __oembedError;
         var disable_private = options.getProviderOptions('soundcloud.disable_private', false)
         if (oembedError === 403 && !disable_private && twitter.player) {
             return cb(null, {