Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove epoch propagation and cleanup for WD #48

Merged
merged 5 commits into from
Oct 22, 2023

Conversation

tomdonaldson
Copy link
Contributor

This PR removes the proposal to use new COOSYS subelements for epoch propagation which was added in PR #40. Preserved from that PR are:

  • the new Makefile target test which uses stilts to validate the standalone file VOTable examples
  • the new VOTable version 1.5 available in the xsd

In addition, the following changes were made to prepare for the next working draft:

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable -- thanks for doing all that work.

It's still a bit of a pity because we'd finally have automatic epoch propagation, but in the interest of getting 1.5 out of the door, then be it.

This is done for consistency with the similar annotation of
TIMESYS/@refposition.
mbtaylor
mbtaylor previously approved these changes Oct 20, 2023
Copy link
Member

@mbtaylor mbtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tom, all looks in order apart from the two small commits I just added and one other thing: should the VOTable.vor record be updated at this stage for v1.5? Or maybe that happens nearer the REC. Maybe @msdemlei can comment on that.

@msdemlei
Copy link
Contributor

msdemlei commented Oct 20, 2023 via email

@tomdonaldson
Copy link
Contributor Author

On Fri, Oct 20, 2023 at 02:25:08AM -0700, Mark Taylor wrote: added and one other thing: should the VOTable.vor record be updated at this stage for v1.5? Or maybe that happens nearer the REC. Maybe @msdemlei can comment on that.
If you're 99% sure that the schema won't change in RFC, having v1.5 in the XSD is all right. If not, I'd vote for leaving it tagged; it's not the end of the world if two VOTable XSDs with @.***="1.5" float around, but it's not pretty either.

I'm seeing 2 separate, but related things here. When should we update VOTable.vor, and what version should I put in the schema now? I take Markus' point on the schema, so I can update that to 1.5pre3 I guess. In preserving the history of the multiple versions, I can restore the original comment for 1.5pre1 as well.

My thinking on the vor file was that that would get updated when building the REC. I'm happy to be corrected on that.

@tomdonaldson
Copy link
Contributor Author

On Fri, Oct 20, 2023 at 02:25:08AM -0700, Mark Taylor wrote: added and one other thing: should the VOTable.vor record be updated at this stage for v1.5? Or maybe that happens nearer the REC. Maybe @msdemlei can comment on that.
If you're 99% sure that the schema won't change in RFC, having v1.5 in the XSD is all right. If not, I'd vote for leaving it tagged; it's not the end of the world if two VOTable XSDs with @.***="1.5" float around, but it's not pretty either.

I'm seeing 2 separate, but related things here. When should we update VOTable.vor, and what version should I put in the schema now? I take Markus' point on the schema, so I can update that to 1.5pre3 I guess. In preserving the history of the multiple versions, I can restore the original comment for 1.5pre1 as well.

My thinking on the vor file was that that would get updated when building the REC. I'm happy to be corrected on that.

@msdemlei are you comfortable with the updated schema version and the unchanged state of VOTable.vor?

@msdemlei
Copy link
Contributor

msdemlei commented Oct 21, 2023 via email

@tomdonaldson tomdonaldson merged commit 9689d58 into ivoa-std:master Oct 22, 2023
1 check passed
@tomdonaldson tomdonaldson added this to the v1.5 milestone Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants