Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit vocabulary lists and paragraph indentation. #50

Merged
merged 9 commits into from
Nov 15, 2023

Conversation

tomdonaldson
Copy link
Contributor

@tomdonaldson tomdonaldson commented Nov 9, 2023

Based on this e-mail thread, I made the following changes:

In removing \parindent=0pt I noticed that we went from 35 to 32 overfull hboxes. Though I'm not sure that's necessarily an improvement, I didn't notice any new display problems in the draft pdf. This look does seem consistent with a couple other docs I looked at (DataLink and TAP). Please have a look for yourself at the pdf artifact generated for this PR.

Regarding whether some attributes of COOSYS should be mandatory to be consistent with TIMESYS, I've added this comment to issue 23, but still think we should maintain backward compatibility until version 2.0.
Please comment that issue if clarification is needed. If you'd to add something to this version warning that certain attributes may become required, please suggest wording here on this PR.

Copy link
Contributor

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with all the changes.

For the headline of the appendix you could consider using version \ivoaDocversion rather than updating things by hand, though.

@tomdonaldson
Copy link
Contributor Author

I've added new commits for the latest apps list comments and to replace several lingering mentions of 1.4 that should have been updated to 1.5.

@tomdonaldson tomdonaldson added this to the v1.5 milestone Nov 11, 2023
Copy link
Member

@mbtaylor mbtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that resetting the \parindent (rather than adding a \parskip as suggested by Francois) results in an aesthetic improvement to the PDF, but if the editor prefers it that way it's fine (I know that \parskip sometimes doesn't behave as expected). Otherwise all looks OK.

@tomdonaldson tomdonaldson merged commit 9180298 into ivoa-std:master Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants