-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit vocabulary lists and paragraph indentation. #50
Explicit vocabulary lists and paragraph indentation. #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with all the changes.
For the headline of the appendix you could consider using version \ivoaDocversion
rather than updating things by hand, though.
I've added new commits for the latest apps list comments and to replace several lingering mentions of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced that resetting the \parindent
(rather than adding a \parskip
as suggested by Francois) results in an aesthetic improvement to the PDF, but if the editor prefers it that way it's fine (I know that \parskip
sometimes doesn't behave as expected). Otherwise all looks OK.
Based on this e-mail thread, I made the following changes:
In removing
\parindent=0pt
I noticed that we went from 35 to 32 overfull hboxes. Though I'm not sure that's necessarily an improvement, I didn't notice any new display problems in the draft pdf. This look does seem consistent with a couple other docs I looked at (DataLink and TAP). Please have a look for yourself at the pdf artifact generated for this PR.Regarding whether some attributes of COOSYS should be mandatory to be consistent with TIMESYS, I've added this comment to issue 23, but still think we should maintain backward compatibility until version 2.0.
Please comment that issue if clarification is needed. If you'd to add something to this version warning that certain attributes may become required, please suggest wording here on this PR.