-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create docker-publish.yml #15
Conversation
attempt to create action to publish this docker image in the GitHub packages repository so that the image might be used in other publishing actions on ivoa docs as the current setup of the publishing actions takes a long time This is just the vanilla publish docker action that the GitHub UI suggests.
looks like the default build is not working anyway - will look at this more.... |
Hi Paul, apologies for not catching this earlier, I was on strike last week so not reading emails. |
even though it looks like a bit of a mess, I think it is harmless for you to must merge - it will just either succeed or fail to publish the image to the GitHub package repo! |
Yep, will do. I'm working through a backlog of emails at the moment. |
When you say the default build is not working, do you mean the |
no. I mean that the GitHub action to do the build and publish the docker image was not working - I think that the docker part is fine - it had got into a bit of a mess with me trying to edit using the GitHub web UI rather than locally as it created two separate PRs for my rather trivial edits. They should both be of the action file - which is why I say you can just run the merges and then we can see where we are - It will not make any difference to external users of the image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
I merged the two PRs, which triggered the automated build.
It looks like the automated build is looking for the Dockerfile at the top level directory, which is confounded by my habit of placing Dockerfiles in a subdirectory. Given the whole purpose of this project is to create a Docker container, it would make sense to move the Dockerfile to the top level directory. see #17 |
attempt to create action to publish this docker image in the GitHub packages repository so that the image might be used in other publishing actions on ivoa docs as the current setup of the publishing actions takes a long time
This is just the vanilla publish docker action that the GitHub UI suggests.