Skip to content

Commit

Permalink
Add latest changes from gitlab-org/gitlab@master
Browse files Browse the repository at this point in the history
  • Loading branch information
GitLab Bot committed Sep 14, 2020
1 parent a483e92 commit a8caa9c
Show file tree
Hide file tree
Showing 79 changed files with 866 additions and 350 deletions.
8 changes: 0 additions & 8 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,6 @@
documentation](doc/development/changelog.md) for instructions on adding your own
entry.

## 13.3.6 (2020-09-14)

### Fixed (2 changes)

- Fixes Auto DevOps deploy script for multiple additional hosts separated by comma and space. !41404
- Use 'read' method to get request body in Conan to fix uploads when using Unicorn. !41801


## 13.3.4 (2020-09-02)

### Security (1 change)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<script>
import { GlDropdown, GlNewDropdownItem, GlSprintf } from '@gitlab/ui';
import { GlDropdown, GlDropdownItem, GlSprintf } from '@gitlab/ui';
import { __, sprintf } from '~/locale';
import allVersionsMixin from '../../mixins/all_versions';
import { findVersionId } from '../../utils/design_management_utils';
export default {
components: {
GlDropdown,
GlNewDropdownItem,
GlDropdownItem,
GlSprintf,
},
mixins: [allVersionsMixin],
Expand Down Expand Up @@ -64,7 +64,7 @@ export default {

<template>
<gl-dropdown :text="dropdownText" size="small">
<gl-new-dropdown-item
<gl-dropdown-item
v-for="(version, index) in allVersions"
:key="version.id"
:is-check-item="true"
Expand All @@ -76,6 +76,6 @@ export default {
{{ allVersions.length - index }}
</template>
</gl-sprintf>
</gl-new-dropdown-item>
</gl-dropdown-item>
</gl-dropdown>
</template>
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
GlFormGroup,
GlFormCheckbox,
GlDropdown,
GlNewDropdownItem,
GlDropdownItem,
} from '@gitlab/ui';
import {
I18N_ALERT_SETTINGS_FORM,
Expand All @@ -25,7 +25,7 @@ export default {
GlIcon,
GlFormCheckbox,
GlDropdown,
GlNewDropdownItem,
GlDropdownItem,
},
inject: ['service', 'alertSettings'],
data() {
Expand Down Expand Up @@ -107,7 +107,7 @@ export default {
:text="issueTemplateHeader"
:block="true"
>
<gl-new-dropdown-item
<gl-dropdown-item
v-for="template in templates"
:key="template.key"
data-qa-selector="incident_templates_item"
Expand All @@ -116,7 +116,7 @@ export default {
@click="selectIssueTemplate(template.key)"
>
{{ template.name }}
</gl-new-dropdown-item>
</gl-dropdown-item>
</gl-dropdown>
</gl-form-group>

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<script>
import { mapState } from 'vuex';
import { GlDropdown, GlNewDropdownItem, GlLink } from '@gitlab/ui';
import { GlDropdown, GlDropdownItem, GlLink } from '@gitlab/ui';
import { s__ } from '~/locale';
import { defaultIntegrationLevel, overrideDropdownDescriptions } from '../constants';
Expand All @@ -20,7 +20,7 @@ export default {
name: 'OverrideDropdown',
components: {
GlDropdown,
GlNewDropdownItem,
GlDropdownItem,
GlLink,
},
props: {
Expand Down Expand Up @@ -74,13 +74,13 @@ export default {
</span>
<input name="service[inherit_from_id]" :value="override ? '' : inheritFromId" type="hidden" />
<gl-dropdown :text="selected.text">
<gl-new-dropdown-item
<gl-dropdown-item
v-for="option in $options.dropdownOptions"
:key="option.value"
@click="onClick(option)"
>
{{ option.text }}
</gl-new-dropdown-item>
</gl-dropdown-item>
</gl-dropdown>
</div>
</template>
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {
GlAlert,
GlButton,
GlDropdown,
GlNewDropdownItem,
GlDropdownItem,
GlDropdownText,
GlFormGroup,
GlFormSelect,
Expand Down Expand Up @@ -35,7 +35,7 @@ export default {
GlAlert,
GlButton,
GlDropdown,
GlNewDropdownItem,
GlDropdownItem,
GlDropdownText,
GlFormGroup,
GlFormSelect,
Expand Down Expand Up @@ -305,14 +305,14 @@ export default {
<gl-loading-icon v-if="isFetching" />
<gl-new-dropdown-item
<gl-dropdown-item
v-for="user in users"
v-else
:key="user.id"
@click="updateMapping(data.item.jiraAccountId, user.id, user.username)"
>
{{ user.username }} ({{ user.name }})
</gl-new-dropdown-item>
</gl-dropdown-item>
<gl-dropdown-text v-show="shouldShowNoMatchesFoundText" class="text-secondary">
{{ __('No matches found') }}
Expand Down
30 changes: 15 additions & 15 deletions app/assets/javascripts/milestones/project_milestone_combobox.vue
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<script>
import {
GlDropdown,
GlNewDropdownDivider,
GlDropdownDivider,
GlNewDropdownHeader,
GlNewDropdownItem,
GlDropdownItem,
GlLoadingIcon,
GlSearchBoxByType,
GlIcon,
Expand All @@ -18,9 +18,9 @@ const SEARCH_DEBOUNCE_MS = 250;
export default {
components: {
GlDropdown,
GlNewDropdownDivider,
GlDropdownDivider,
GlNewDropdownHeader,
GlNewDropdownItem,
GlDropdownItem,
GlLoadingIcon,
GlSearchBoxByType,
GlIcon,
Expand Down Expand Up @@ -200,7 +200,7 @@ export default {
<span class="text-center d-block">{{ $options.translations.selectMilestone }}</span>
</gl-new-dropdown-header>

<gl-new-dropdown-divider />
<gl-dropdown-divider />

<gl-search-box-by-type
ref="searchBox"
Expand All @@ -211,26 +211,26 @@ export default {
@keydown.enter.prevent="onSearchBoxEnter"
/>

<gl-new-dropdown-item @click="onMilestoneClicked(null)">
<gl-dropdown-item @click="onMilestoneClicked(null)">
<span :class="{ 'pl-4': true, 'selected-item': selectedMilestones.length === 0 }">
{{ $options.translations.noMilestone }}
</span>
</gl-new-dropdown-item>
</gl-dropdown-item>

<gl-new-dropdown-divider />
<gl-dropdown-divider />

<template v-if="isLoading">
<gl-loading-icon />
<gl-new-dropdown-divider />
<gl-dropdown-divider />
</template>
<template v-else-if="noResults">
<div class="dropdown-item-space">
<span ref="noResults" class="pl-4">{{ $options.translations.noResultsLabel }}</span>
</div>
<gl-new-dropdown-divider />
<gl-dropdown-divider />
</template>
<template v-else-if="dropdownItems.length">
<gl-new-dropdown-item
<gl-dropdown-item
v-for="item in dropdownItems"
:key="item"
role="milestone option"
Expand All @@ -239,12 +239,12 @@ export default {
<span :class="{ 'pl-4': true, 'selected-item': isSelectedMilestone(item) }">
{{ item }}
</span>
</gl-new-dropdown-item>
<gl-new-dropdown-divider />
</gl-dropdown-item>
<gl-dropdown-divider />
</template>

<gl-new-dropdown-item v-for="(item, idx) in extraLinks" :key="idx" :href="item.url">
<gl-dropdown-item v-for="(item, idx) in extraLinks" :key="idx" :href="item.url">
<span class="pl-4">{{ item.text }}</span>
</gl-new-dropdown-item>
</gl-dropdown-item>
</gl-dropdown>
</template>
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import {
GlFormGroup,
GlFormInput,
GlDropdown,
GlNewDropdownItem as GlDropdownItem,
GlDropdownItem,
GlModal,
GlTooltipDirective,
GlIcon,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { mapState, mapGetters, mapActions } from 'vuex';
import {
GlDeprecatedButton,
GlDropdown,
GlNewDropdownDivider,
GlNewDropdownItem,
GlDropdownDivider,
GlDropdownItem,
GlModal,
GlIcon,
GlModalDirective,
Expand All @@ -24,8 +24,8 @@ export default {
components: {
GlDeprecatedButton,
GlDropdown,
GlNewDropdownDivider,
GlNewDropdownItem,
GlDropdownDivider,
GlDropdownItem,
GlModal,
GlIcon,
DuplicateDashboardModal,
Expand Down Expand Up @@ -157,13 +157,13 @@ export default {
</template>
<template v-if="addingMetricsAvailable">
<gl-new-dropdown-item
<gl-dropdown-item
v-gl-modal="$options.modalIds.addMetric"
data-qa-selector="add_metric_button"
data-testid="add-metric-item"
>
{{ $options.i18n.addMetric }}
</gl-new-dropdown-item>
</gl-dropdown-item>
<gl-modal
ref="addMetricModal"
:modal-id="$options.modalIds.addMetric"
Expand Down Expand Up @@ -194,62 +194,62 @@ export default {
</gl-modal>
</template>
<gl-new-dropdown-item
<gl-dropdown-item
v-if="isMenuItemEnabled.addPanel"
data-testid="add-panel-item-enabled"
:to="newPanelPageLocation"
>
{{ $options.i18n.addPanel }}
</gl-new-dropdown-item>
</gl-dropdown-item>
<!--
wrapper for tooltip as button can be `disabled`
https://bootstrap-vue.org/docs/components/tooltip#disabled-elements
-->
<div v-else v-gl-tooltip :title="$options.i18n.addPanelInfo">
<gl-new-dropdown-item
<gl-dropdown-item
:alt="$options.i18n.addPanelInfo"
:to="newPanelPageLocation"
data-testid="add-panel-item-disabled"
disabled
class="gl-cursor-not-allowed"
>
<span class="gl-text-gray-400">{{ $options.i18n.addPanel }}</span>
</gl-new-dropdown-item>
</gl-dropdown-item>
</div>
<gl-new-dropdown-item
<gl-dropdown-item
v-if="isMenuItemEnabled.editDashboard"
:href="selectedDashboard ? selectedDashboard.project_blob_path : null"
data-qa-selector="edit_dashboard_button_enabled"
data-testid="edit-dashboard-item-enabled"
>
{{ $options.i18n.editDashboard }}
</gl-new-dropdown-item>
</gl-dropdown-item>
<!--
wrapper for tooltip as button can be `disabled`
https://bootstrap-vue.org/docs/components/tooltip#disabled-elements
-->
<div v-else v-gl-tooltip :title="$options.i18n.editDashboardInfo">
<gl-new-dropdown-item
<gl-dropdown-item
:alt="$options.i18n.editDashboardInfo"
:href="selectedDashboard ? selectedDashboard.project_blob_path : null"
data-testid="edit-dashboard-item-disabled"
disabled
class="gl-cursor-not-allowed"
>
<span class="gl-text-gray-400">{{ $options.i18n.editDashboard }}</span>
</gl-new-dropdown-item>
</gl-dropdown-item>
</div>
<template v-if="isMenuItemShown.duplicateDashboard">
<gl-new-dropdown-item
<gl-dropdown-item
v-gl-modal="$options.modalIds.duplicateDashboard"
data-testid="duplicate-dashboard-item"
>
{{ $options.i18n.duplicateDashboard }}
</gl-new-dropdown-item>
</gl-dropdown-item>
<duplicate-dashboard-modal
:default-branch="defaultBranch"
Expand All @@ -259,25 +259,25 @@ export default {
/>
</template>
<gl-new-dropdown-item
<gl-dropdown-item
v-if="selectedDashboard"
data-testid="star-dashboard-item"
:disabled="isUpdatingStarredValue"
@click="toggleStarredValue()"
>
{{ selectedDashboard.starred ? $options.i18n.unstarDashboard : $options.i18n.starDashboard }}
</gl-new-dropdown-item>
</gl-dropdown-item>
<gl-new-dropdown-divider />
<gl-dropdown-divider />
<gl-new-dropdown-item
<gl-dropdown-item
v-gl-modal="$options.modalIds.createDashboard"
data-testid="create-dashboard-item"
:disabled="!isMenuItemEnabled.createDashboard"
:class="{ 'monitoring-actions-item-disabled': !isMenuItemEnabled.createDashboard }"
>
{{ $options.i18n.createDashboard }}
</gl-new-dropdown-item>
</gl-dropdown-item>
<template v-if="isMenuItemEnabled.createDashboard">
<create-dashboard-modal
Expand Down
Loading

0 comments on commit a8caa9c

Please sign in to comment.