Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add listen-port and key-path #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add listen-port and key-path #58

wants to merge 1 commit into from

Conversation

dmarzzz
Copy link
Contributor

@dmarzzz dmarzzz commented May 27, 2024 •
edited
Loading

  • adds some additional debug logging
  • adds listen-port and key-path command line flags
  • updates usage in PoC readme

This was referenced May 27, 2024
Open
Open
abstraking
abstraking approved these changes Jun 2, 2024
View reviewed changes
Copy link
Contributor

@abstraking abstraking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have only one improvement suggestion. Looks good otherwise, thanks!

unison-poc/main.go
flag.IntVar(&networkSize, "network-size", 0, "Expected network size to wait for before starting the network. SKips if 0")
flag.IntVar(&networkSize, "network-size", 0, "Expected network size to wait for before starting the network. Skips if 0")
flag.IntVar(&listenPort, "listen-port", 10000, "Port to listen on for libp2p connections")
flag.StringVar(&keyPath, "key-path", "/.unison/key", "Path to the p2p private key")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to specify the path to the unison folder only. We may want to add more persistent data to PoC besides the key and define every single persistence through the flag as not scalable. The key file name can be constant and defined close to the getIndentity function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will try to incorporate today or tomorrow 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abstraking abstraking abstraking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmarzzz @abstraking