This repository was archived by the owner on Nov 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Docker support for unit tests #23
Open
swharden
wants to merge
6
commits into
j6s:development
Choose a base branch
from
swharden:docker
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that 1 test currently fails: #22
j6s
suggested changes
Oct 2, 2021
j6s
reviewed
Oct 2, 2021
j6s
reviewed
Oct 2, 2021
Curiously, I could not reproduce #22 - after checking out that branch and running the compose setup, it worked on my machine (TM) |
When starting from a clean repository without a
|
CI using GitHub Actions to build docker container used for running PHP tests
installs git and zip so vendor files can be downloaded and extracted
Thanks for pointing that out! To prevent "it works on my machine" problems like this I created another GitHub action that builds the docker container (and runs the tests inside it) in the cloud. I'm not proposing this replace the tests that already run in the cloud (#24), but this will at least let you spot-check that the testing container is building as expected. If it's not helpful you may wish to modify it so it only runs manually (not on every push). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added docker files to the home directory and added notes at the bottom of the main readme to make it easy for new developers to run/test phparch in a Linux container
Note that 1 test currently fails: #22