-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PACK-1 & PACK-2 #5
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
…vy Launcher, but should in Python-For-Android) Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
BTW, I think the next step really should be PACK-3, we should try to render Zim notes as HTML asap, and later do the UI-1 to UI-3 milestones. I would like to ensure that rendering Zim notes is possible (particularly I am worried about the dependencies required by Zim, as Kivy Launcher is quite picky...). @jaap-karssenberg Could you maybe add to the repo the minimal set of python files from Zim that are required to read a Zim note and convert it to HTML? I could then give it a try on Android. |
Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
…edition, including in Android! Signed-off-by: Stephen L. <[email protected]>
Signed-off-by: Stephen L. <[email protected]>
A bit in advance of UI-3, I just tested Of course the changes are not stored anywhere, we would need to implement a MutationObserver (if an expert of Javascript is passing by, please give us a hand!), but other than that it works well. I previously heard that there were issues with the editing cursor on Android but I did not see any such issue, the rendering during edition is instantaneous and perfect :-) |
Signed-off-by: Stephen L. <[email protected]>
I could compile an APK! I did not test it though, but at least it compiles, so it's now only a matter of giving the correct arguments to include all the necessary packages. I added instructions for compilation in DEVELOPER.md. Note that I did not add these instructions to the wiki but in md files inside my repo, because the instructions are for the moment subject to change, they are related to a specific version of the mockup. When it will be more mature then it might be a good idea to move them to the wiki :-) |
I think I've found the perfect javascript editor for Zim: https://github.com/nhnent/tui.editor It is made for Markdown but it should be relatively easy to convert to Zim syntax :-) |
Hi Stephen, Apologies for the slow response time, I'm "underwater" doing the Gtk3 port, which I can only complete by blocking part of my inbox. Great to see this merge request and such progress! Will have a more detailed look in another ~ 2 weeks and merge it. Regards, Jaap |
@jaap-karssenberg Great! No problem as anyway I can't work on it again until at least March, so no hurry but when you're done with GTK3 if you can help with providing a minimal Zim -> html decoder I can give a try at PACK-3, so we could have a working Zim reader for Android :-) (PS: when I say minimal I mean with minimal 3rd-party dependencies, we just need a Zim -> HTML converter, text only, just so that I can try to compile on Android) |
@jaap-karssenberg Is the pull request still going to be merged some day (or is this repo not maintained anymore)? I'm a big fan of the Zim Desktop Wiki and would be interested to participate in the development of an app in the long run, but the project seems to be more or less dead at the moment... |
This PR contains PACK-1 (for both desktop and Android, so it will ease development) as well as PACK-2 (all instructions are in DEVELOPER.md). This is done using Kivy. No compilation is necessary for the moment (although it is possible, ie to package as a standalone APK, more in DEVELOPER.md).
Here is the result on Android:
Note this PR contains alternatives for the service (service2-4). I left them here in case they can be useful further in development but they are unused as of now, wsgiref seems to do the job well :-)
Note also that one of my high priority goals was to minimize the burden of developing for Android, thus: