Release v8.0.3 #488
Merged
Release v8.0.3 #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove deprecated code * Remove old codeql config * Remove unused fixture * Minor clean up * Refactor async_post_request Signed-off-by: Tobias Sauerwein <[email protected]> --------- Signed-off-by: Tobias Sauerwein <[email protected]>
* split tests * clean up cruft * Fix NLPD to provide energy readings * Add BNLD - Bticino dimmable light
* Clean up somfy shutter * Add new bticino scope * update readme
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.7.1 to 5.0.0. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4.7.1...v5.0.0) --- updated-dependencies: - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add missing NLFE Legrand dimmer switch * clean up * Update changelog
* Update BNCS * feat: add centralized ventilation controller NLLF
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Type: Enhancement
PR Summary: The pull request introduces enhancements to the pyatmo library by adding support for new device types, specifically a centralized ventilation controller (NLLF) and a controlled socket (BNCS). It includes updates to the module classes, device type enumerations, and the changelog to reflect these additions. The PR also includes various updates to the test suite to cover the new functionality.
Decision: Comment
📝 Type: 'Enhancement' - not supported yet.
- Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
- Unsupported files: the diff contains files that Sourcery does not currently support during reviews.
General suggestions:
- Ensure that the newly introduced classes are fully implemented and integrated with the rest of the system, as some classes like 'Fan' appear to be placeholders without any methods or properties.
- Review the hardcoded fan speed clamping logic to ensure it is maintainable and consider using constants or configuration parameters for better flexibility.
- Verify that the 'type: ignore' comment is still necessary and remove it if the referenced mypy issue has been resolved.
- Check the consistency of the changelog links and ensure they point to the correct comparison ranges.
Your trial expires on January 15, 2024. Please email [email protected] to continue using Sourcery ✨
Did you find the review useful? React with a 👍 or 👎 to each comment
cgtobi
commented
Jan 13, 2024
cgtobi
added a commit
that referenced
this pull request
Aug 18, 2024
* Release v8.0.3 (#488) * Update BNCS * feat: add centralized ventilation controller NLLF --------- Signed-off-by: Tobias Sauerwein <[email protected]> * Initial commit for support of all schedule types, and fix for historical energy data * Corrected devices to use hstoryMixin to get energy * Merged historyMixin and Energy has they are effectively doing the sum, introduces a sum energy and an helper to be used in homeassistant primarily * removed the daily update * added a reset measures method to be used directly by external libreries * reset now resets timings too * Try to get a proper historical data in case of peak / off_peak energy mode, add some tests * Fixed correctly the timing end/start of measures * Fixed correctly the timing end/start of measures * Fixed correctly the timing end/start of measures * support correct empty measures * removed specidif energy exception to use th egeneric API error, 0lus some logging * removed specidif energy exception to use th egeneric API error, 0lus some logging * removed specidif energy exception to use th egeneric API error, 0lus some logging * removed specidif energy exception to use th egeneric API error, 0lus some logging * async update for all homes * async update for all homes * async update for all homes * async update for all homes * async update for all homes * async update for all homes * async update for all homes * async update for all homes * async update for all homes * added some tests for historical data * added some tests for historical data * added a way to get the data sum * added throttling exception * fix for num calls estimation * fix for num calls estimation * changed type for energy * changed type for energy * Added historical retrival for other state, begining only for power (to be used to refine homeassistant energy handling * Added historical retrival for other state, begining only for power (to be used to refine homeassistant energy handling * Added historical retrival for other state, begining only for power (to be used to refine homeassistant energy handling * Added historical retrival for other state, begining only for power (to be used to refine homeassistant energy handling * Added historical retrival for other state, begining only for power (to be used to refine homeassistant energy handling * Added historical retrival for other state, begining only for power (to be used to refine homeassistant energy handling * Added historical retrival for other state, begining only for power (to be used to refine homeassistant energy handling * Added historical retrival for other state, begining only for power (to be used to refine homeassistant energy handling * all tests pass * added energy sum * added energy sum * added energy sum * added energy sum * PEP cleaning to prepare PR * adjusting estimation calculus * adjusting estimation calculus * adjusting estimation calculus * slight refactor for readability * Support error for unreachable home and bridges ....it is an error, not a normal call * Support error for unreachable home and bridges ....it is an error, not a normal call * remove global energy sum support, no needed anymore, was adding complexity * remove global energy sum support, no needed anymore, was adding complexity * refactor to use self.homes where it should be * setting schedules list back as the global list of schedules, for retro-compatibility * Black.... * Ruff.... * Ruff.... * Ruff.... * Ruff.... then black funny game * black.... then ruff funny game * black and ruff game * black and ruff game * YABT .. yet another Black Test * Cleaned supported homes with a way simpler approach, thx @cgtobi * keep black API * keep black API * Added back a list of available homes to be able to select the one needed or not * white space * Merge remote-tracking branch 'refs/remotes/upstream/development' into development # Conflicts: # src/pyatmo/modules/bticino.py * Support NLE "connected ecocometer" that is a bridge * Support NLE "connected ecocometer" that is a bridge...and has no power data in teh homestatus API * Support NLE "connected ecocometer" that is a bridge...and has no power data in teh homestatus API * Support NLE "connected ecocometer" that is a bridge...and has no power data in teh homestatus API * Black / Rust * Black / Rust * Black / Rust * Remove schedule code API calls, etc ... to make it compatible with old lib * Remove schedule code API calls, etc ... to make it compatible with old lib * Remove schedule code API calls, etc ... to make it compatible with old lib * Remove schedule code API calls, etc ... to make it compatible with old lib * Black / Rust * Black / Rust * Black / Rust * Black / Rust * Black / Rust * Black / Ruff * Black / Ruff * some first remarks from PR fixes * removed home update boolean as output, and raise conditionally a reachability error * removed home update boolean as output, and raise conditionally a reachability error * rieman energy method extraction * last PR comments * black / ruff --------- Signed-off-by: Tobias Sauerwein <[email protected]> Co-authored-by: Tobias Sauerwein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.