fixes #14, default color in new transparent image should be black

jabiercoding · Sep 28, 2016 · 8998e8a · trkndi17 · Oct 2, 2020 · trkndi17
1 parent b77ada0
commit 8998e8a
Showing 1 changed file with 13 additions and 3 deletions.
diff --git a/plugins/org.eclipaint.editor/src/org/eclipaint/editor/ImageEditor.java b/plugins/org.eclipaint.editor/src/org/eclipaint/editor/ImageEditor.java
@@ -192,16 +192,26 @@ private void createToolItems(ToolBar toolBar) {
 		currentColorToolItem.setToolTipText("Current color");
 
 		// initialize color selection
-		// get first non transparent one
+		// get first completely non-transparent color
 		for (PixelItem item : pixels) {
 			if (item.alpha == 255) {
 				colorPickerSelection = (PixelItem) item.clone();
 				break;
 			}
 		}
-		// if not found, get the first color
+		// get first non-transparent color
+		for (PixelItem item : pixels) {
+			if (item.alpha != 0) {
+				colorPickerSelection = (PixelItem) item.clone();
+				break;
+			}
+		}
+		// if not found, get black
 		if (colorPickerSelection == null) {
-			colorPickerSelection = (PixelItem) pixels.get(0).clone();
+			PixelItem pixelItem = (PixelItem) pixels.get(0).clone();
+			pixelItem.alpha = 255;
+			pixelItem.color = new RGB(0,0,0);
+			colorPickerSelection = pixelItem;
 		}
 		currentColorToolItem.setImage(EditorUtils.createImageForColorSelection(colorPickerSelection.color,
 				colorPickerSelection.alpha));