Add tests CI workflow #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the rdoc dependency (and .document file) since its not used and the Rakefile now matches what Bundler generates for a new gem. This also moves the development dependencies from the gemspec to the Gemfile to be consistent with Bundler gem template.
We never ended up using this gem from this commit but actually the one before, commit e5b0be0, so it's safe and best to revert this unused change so it stays as it was.
The first tests are commented out because of commit e5b0be0 so this is expected to fail. The second test failure I'm not sure how it passed before but on Ruby 3.3 or even 3.0, I still get this value which is expected considering the code calls `to_json` on the body: ``` # Ruby 3.3.5p100 >> nil.to_json => "null" ```
javierjulio
force-pushed
the
ci-ruby
branch
from
8940fdc to
a14b158
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test workflow and some general clean up.