WIP: Better matrix support #426
Open
+1,113
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An optional argument was added that provides the # of values from the json file for each row within the matrix. This allows the user to more easily know if not all of the rows had the same number of columns.
- Update with latest upstream enhancements 6.9.0 --> 6.10.0
Fixes the undefined variable error_cnt for test jacobwilliams#26 when the json%validate returns a true is_valid statement.
Fix for undefined variable in test#26
…dd_matrix_support
- MSVS will install, e.g., `$<prefix>/include/Debug/json_file_module.mod` - We should strip the build config directory that IDEs like MSVS add when doing an installation
…ran into add_matrix_support
- Fixes jacobwilliams#413 - Use fixtures to delete old json outputs before re-running tests, then copy pristine inputs back into the build directory
…dd_matrix_support
Open
- Add additional optional, intent out parameter, `is_uniform` - `.true.` for regular matrices - `.false.` for ragged edge matrices - The idea is to allow trailing zeros to be compressed/elided (eventually) - The `set_size` dummy argument was renamed to `mx_set_size` and records the largest column size, assuming __*row* major order__
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE THIS, WIP!
I just wanted to have a place to look at the diff and discuss implementation details while I work on wrapping this up.
Goals:
Thoughts @jacobwilliams & @porteri?