Replace NumPy with PyTorch in PositionalEncoding #207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR replaces the usage of NumPy with PyTorch in the PositionalEncoding class, specifically in the _get_sinusoid_encoding_table method. The goal is to make the function compatible with PyTorch and take advantage of GPU acceleration when available.
Changes:
Replace np.array with torch.tensor for creating the sinusoid table.
Replace np.power with torch.pow for calculating the position angle vector.
Change the data type from NumPy float array to PyTorch float tensor.
Here's the modified _get_sinusoid_encoding_table method: